skopeo icon indicating copy to clipboard operation
skopeo copied to clipboard

[WIP] Makefile: set CONTAINERSCONFDIR based on the OS

Open lsm5 opened this issue 4 years ago • 9 comments
trafficstars

This will put config dir under $PREFIX for FreeBSD.

Continuing PR#1298 by @mateuszkwiatkowski.

Fixes: #787

Signed-off-by: Lokesh Mandvekar [email protected]

lsm5 avatar Nov 16 '21 20:11 lsm5

@glensc @mateuszkwiatkowski would either of you have the time to give this a try please?

lsm5 avatar Nov 16 '21 20:11 lsm5

PR #1298 - i like links

glensc avatar Nov 16 '21 21:11 glensc

@lsm5 LGTM:

  • https://github.com/Homebrew/homebrew-core/pull/89524#issuecomment-970721779

glensc avatar Nov 16 '21 22:11 glensc

A friendly reminder that this PR had no activity for 30 days.

github-actions[bot] avatar Dec 18 '21 00:12 github-actions[bot]

Can this be finished? so i don't have to bump brew PR to keep it active:

  • https://github.com/Homebrew/homebrew-core/pull/89524#issuecomment-1008857642

glensc avatar Jan 10 '22 14:01 glensc

@glensc @lsm5 is on PTO until the end of the month, I believe. If you want this to move forward, I suggest you take it over and open a new PR, following @mtrmac recommendations.

rhatdan avatar Jan 10 '22 14:01 rhatdan

Changes in the meantime: #1642 + https://github.com/containers/image/pull/1544 will move the config files to /usr/local/etc on FreeBSD (but not macOS like this PR also does); the transition will be an incompatible break but at least it will (eventually) be consistent with other c/image users.

At least the other aspect of this PR, making the directory overrides turn into c/image built-in path overrides, is still valuable and desirable for #787 .

mtrmac avatar May 10 '22 20:05 mtrmac

A friendly reminder that this PR had no activity for 30 days.

github-actions[bot] avatar Jun 27 '22 00:06 github-actions[bot]

A friendly reminder that this PR had no activity for 30 days.

github-actions[bot] avatar Dec 16 '23 00:12 github-actions[bot]