ramalama icon indicating copy to clipboard operation
ramalama copied to clipboard

Some initial proxy code

Open ericcurtin opened this issue 6 months ago • 1 comments

This creates an model swapping layer between the client and inferencing server.

Summary by Sourcery

New Features:

  • Create a model swapping intermediary layer in the serving core

ericcurtin avatar May 04 '25 10:05 ericcurtin

Reviewer's Guide

This pull request introduces a proxy layer within the ramalama-serve-core executable by modifying its core logic to intercept client requests and route them to the appropriate inference server, enabling model swapping.

File-Level Changes

Change Details Files
Implemented a proxy layer for model swapping within the core serving executable.
  • Modified the core serving logic to insert a proxy layer.
  • Added functionality to handle model swapping based on incoming requests.
libexec/ramalama/ramalama-serve-core

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an issue from a review comment by replying to it. You can also reply to a review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull request title to generate a title at any time. You can also comment @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in the pull request body to generate a PR summary at any time exactly where you want it. You can also comment @sourcery-ai summary on the pull request to (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the pull request to resolve all Sourcery comments. Useful if you've already addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull request to dismiss all existing Sourcery reviews. Especially useful if you want to start fresh with a new review - don't forget to comment @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

  • Contact our support team for questions or feedback.
  • Visit our documentation for detailed guides and information.
  • Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai[bot] avatar May 04 '25 10:05 sourcery-ai[bot]

A friendly reminder that this PR had no activity for 30 days.

github-actions[bot] avatar Jul 24 '25 00:07 github-actions[bot]

@ericcurtin any update on this or should we close?

rhatdan avatar Jul 24 '25 10:07 rhatdan

Since server-core is no longer used, closing. This effort will need to be restarted next week.

rhatdan avatar Jul 25 '25 12:07 rhatdan

Closing is fine, I won't finish this, although this is along the lines of what "ramalama serve" should look like, "ramalama serve some_model" remaining as is

ericcurtin avatar Jul 25 '25 13:07 ericcurtin