Use gvisor-tap-vsock version from go.mod file

[evidolob]

trafficstars

Discussion there https://github.com/containers/gvisor-tap-vsock/issues/475

Does this PR introduce a user-facing change?

None

[evidolob]

cc @Luap99

[baude]

yeah, LGTM ... @cfergeau this look ok to you and no planned changes with gvproxy that would break this ?

[cfergeau]

yeah, LGTM ... @cfergeau this look ok to you and no planned changes with gvproxy that would break this ?

Looks fine to me, and I don’t expect changes in gvproxy which would break this.

[Luap99]

@evidolob Still working on this? It would be great to have this ready by next Tuesday so we have the right versions in the 5.5-rc1 installer.

[evidolob]

@Luap99 I'v rebase PR, not sure what I need to do more.

[cfergeau]

The "Validate source code changes" fails with:

Validating vs commit '7d6c4f9a47e5ea07781df2836a5c88990becaca3'
GIT_CHECK_EXCLUDE="./vendor:./test/tools/vendor:docs/make.bat:test/buildah-bud/buildah-tests.diff:test/e2e/quadlet/remap-keep-id2.container" ./test/tools/build/git-validation -run short-subject -range 7d6c4f9a47e5ea07781df2836a5c88990becaca3..HEAD
time="2025-04-18T02:02:18-05:00" level=info msg="using commit range: 7d6c4f9a47e5ea07781df2836a5c88990becaca3..HEAD"
 * 60074bcbc9 "Use gvisor-tap-vsock version from go.mod file Discussion there https://github.com/containers/gvisor-tap-vsock/issues/475" ... FAIL
  - FAIL - commit subject exceeds 90 characters

[cfergeau]

I think you need to add a blank line after the short log:

Use gvisor-tap-vsock version from go.mod file

Discussion there https://github.com/containers/gvisor-tap-vsock/issues/475
    
Signed-off-by: Yevhen Vydolob <[email protected]>

In general it’s better to add a short summary of the discussion directly in the log so that people browsing the log don’t have to switch to their browser to get the context.

[benoitf]

@evidolob it looks like there is a conflict

[benoitf]

I fixed the conflict (it was only the version of vfkit conflicting)

[benoitf]

/retest

[Luap99]

This still seems to be missing https://github.com/containers/podman/pull/25688#discussion_r2021592883 which looks like a more robust way then using grep/cut.

[benoitf]

@Luap99 5.5 is for today ? To know if I should try to amend @evidolob PR so it gets in 5.5

[Luap99]

@benoitf We likely don't manage today. cc @mheon

In any case you are right we should make sure this is part of the rc1 cut, I restarted the flakes and I am fine to merge without the minor change of using go list, we can always do that later.

/lgtm

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evidolob, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [Luap99]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[mheon]

5.5 RC1 slipped a day due to Buildah vendor not being ready

[benoitf]

follow-up PR https://github.com/containers/podman/pull/25949