e2e tests: fix desired network backend checking

[chuanchang]

Setting 'cni' as the network backend then run e2e tests, the following test failure will be hit w/o this patch.

# ./test/tools/build/ginkgo -v -focus "Podman info: check desired network backend" test/e2e/ ... Podman Info [It] Podman info: check desired network backend /root/podman/test/e2e/info_test.go:156

[FAILED] Expected <string>: cni to equal <string>: netavark

Does this PR introduce a user-facing change?

It's only for testing.

[root@dell-r730-059 ~]# cat /etc/redhat-release 
Red Hat Enterprise Linux release 9.6 Beta (Plow)

[root@dell-r730-059 ~]# rpm -q podman crun criu kernel
podman-5.4.0-1.el9.x86_64
crun-1.19.1-1.el9.x86_64
criu-3.19-1.el9.x86_64
kernel-5.14.0-570.3.1.el9_6.x86_64

[openshift-ci[bot]]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chuanchang Once this PR has been reviewed and has the lgtm label, please assign ygalblum for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[chuanchang]

I'm not familar with the contrib/cirrus/setup_environment.sh, please let me know if it's necessary to add 'CI_DESIRED_NETWORK_BACKEND' into the setup_environment.sh, thanks!

[chuanchang]

I mean we removed that because we don't want to support CNI anymore upstream.

Sure we can make this test work again but overall any new test will only be tested on netavark and I don't want to keep adding these skipIfCNI conditions in upstream code, we should be removing them instead.

If that is the only issue you noticed I am fine merging it but I don't want to patch many tests just to work with cni again.

Got it, please close this PR if we don't want to support CNI again, thanks!

[github-actions[bot]]

A friendly reminder that this PR had no activity for 30 days.