podman icon indicating copy to clipboard operation
podman copied to clipboard

Handle default system connection transfer properly on machine removal

Open jakecorrenti opened this issue 1 year ago • 3 comments

Changes system connection removal so the following case now works as expected:

  • Rootless podman machine 1 is initialized and running.
  • Rootful podman machine 2 is initialized.
  • Delete podman machine 1.
  • The rootful system connection associated with podman machine 2 now becomes the default, not the rootless.

Fixes: #22577

Does this PR introduce a user-facing change?

When a user has a rootless machine running and another rootful podman machine initialized, and the rootless machine is removed, the rootful system connection associated with the podman machine now becomes the default as expected.

jakecorrenti avatar Sep 12 '24 19:09 jakecorrenti

ok , LGTM (one question)

baude avatar Sep 13 '24 12:09 baude

Ephemeral COPR build failed. @containers/packit-build please check.

~something's wrong with my macOS env... I don't think this will end up passing the test. Looking into it~

jakecorrenti avatar Sep 25 '24 14:09 jakecorrenti

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakecorrenti, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [Luap99,jakecorrenti]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 27 '24 13:09 openshift-ci[bot]