podman icon indicating copy to clipboard operation
podman copied to clipboard

Quadlet override service name

Open ygalblum opened this issue 1 year ago • 1 comments

Does this PR introduce a user-facing change?

Yes

Allow overriding the service name on all Quadlet unit types
Due to dependency enforcement, all referenced Quadlet files must exist even on dryrun 

ygalblum avatar Jul 30 '24 13:07 ygalblum

@Luap99 this is the PR that completes the support for overriding the generated service name. In addition to the code changes, it required some adjustments to the tests in addition to some new tests

ygalblum avatar Aug 05 '24 12:08 ygalblum

@ygalblum could you rebase and repush.

rhatdan avatar Aug 07 '24 10:08 rhatdan

@rhatdan Done

ygalblum avatar Aug 07 '24 10:08 ygalblum

@containers/podman-maintainers PTAL

ygalblum avatar Aug 11 '24 15:08 ygalblum

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, rhatdan, ygalblum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [Luap99,rhatdan,ygalblum]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 12 '24 13:08 openshift-ci[bot]