podman icon indicating copy to clipboard operation
podman copied to clipboard

Add libkrun Mac task

Open cevich opened this issue 1 year ago • 6 comments

Depends on: https://github.com/containers/automation/pull/208 + deployment into worker pool.

Does this PR introduce a user-facing change?

None

cevich avatar Jul 16 '24 14:07 cevich

Initial test-run

  1. Note: w/o brew install vfkit commented out, the brew install krunkit command fails with some "unlink" error. It's essentially complaining that /some/path/bin/vfkit already exists.

cevich avatar Jul 16 '24 17:07 cevich

Testing note: Confirmed (expected) libkrun tests all fail when run on Mac's w/o libkrun.

cevich avatar Jul 16 '24 17:07 cevich

Opened https://github.com/containers/podman/issues/23296

cevich avatar Jul 16 '24 20:07 cevich

@edsantiago and/or @baude if you want to give the first two commits an initial look over, this PR is code-complete once https://github.com/containers/automation/pull/208 is merged and deployed to the pool management VM (after I'm back from PTO).

cevich avatar Jul 17 '24 15:07 cevich

FYI- I'll be off on PTO next week, so won't be enabling libkrun testing in Podman until I return. There are changes needed on the Mac's used for CI and I don't want to risk breaking something while I'm away.

cevich avatar Jul 19 '24 12:07 cevich

The libkrun mac tests are also passing. I will merge https://github.com/containers/automation/pull/208 shortly, then after a day or so this PR can have final review and testing performed (i.e. after the pool has updated).

cevich avatar Jul 31 '24 20:07 cevich

This PR can move forward on/after 2024-08-01T18:50:12+00:00, by then all the Macs in the pool will be running the new setup.

cevich avatar Jul 31 '24 20:07 cevich

Force-push:

  • Removed DO NOT MERGE commit to clear up diff (this still isn't ready to merge).
  • Renamed mac TEST_FLAVOR values to be consistent w/ other podman-machine testing tasks. (so they all sort together in the status page).

cevich avatar Aug 01 '24 13:08 cevich

This is ready for final review and (assuming CI passes) merging.

cevich avatar Aug 01 '24 19:08 cevich

Looks like the MacOS PM tests are both green, applehv and libkrun

cevich avatar Aug 01 '24 19:08 cevich

LGTM @mheon @baude @Luap99 PTAL

rhatdan avatar Aug 01 '24 20:08 rhatdan

/lgtm

mheon avatar Aug 01 '24 22:08 mheon

/approve

rhatdan avatar Aug 02 '24 07:08 rhatdan

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 02 '24 07:08 openshift-ci[bot]