podman
podman copied to clipboard
Add libkrun Mac task
Depends on: https://github.com/containers/automation/pull/208 + deployment into worker pool.
Does this PR introduce a user-facing change?
None
- All but one (not a flake) of the Mac PM tests pass w/ libkrun. Looked at the code for the failure, can't understand the test or why it would fail with a "file no found" error.
- All of the Mac PM tests fail w/ applehv. Suspect it has to do with needing to comment out the installation of vfkit[0].
- Note: w/o
brew install vfkitcommented out, thebrew install krunkitcommand fails with some "unlink" error. It's essentially complaining that/some/path/bin/vfkitalready exists.
Testing note: Confirmed (expected) libkrun tests all fail when run on Mac's w/o libkrun.
Opened https://github.com/containers/podman/issues/23296
@edsantiago and/or @baude if you want to give the first two commits an initial look over, this PR is code-complete once https://github.com/containers/automation/pull/208 is merged and deployed to the pool management VM (after I'm back from PTO).
FYI- I'll be off on PTO next week, so won't be enabling libkrun testing in Podman until I return. There are changes needed on the Mac's used for CI and I don't want to risk breaking something while I'm away.
The libkrun mac tests are also passing. I will merge https://github.com/containers/automation/pull/208 shortly, then after a day or so this PR can have final review and testing performed (i.e. after the pool has updated).
This PR can move forward on/after 2024-08-01T18:50:12+00:00, by then all the Macs in the pool will be running the new setup.
Force-push:
- Removed
DO NOT MERGEcommit to clear up diff (this still isn't ready to merge). - Renamed mac
TEST_FLAVORvalues to be consistent w/ other podman-machine testing tasks. (so they all sort together in the status page).
This is ready for final review and (assuming CI passes) merging.
LGTM @mheon @baude @Luap99 PTAL
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cevich, rhatdan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [rhatdan]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment