[CI:DOCS] Installer: use latest wix in windows installer

[lsm5]

trafficstars

Does this PR introduce a user-facing change?

None

[packit-as-a-service[bot]]

Ephemeral COPR build failed. @containers/packit-build please check.

[ashley-cui]

The wix version probably also needs to be updated here, as it looks like we're hardcoding WiX 3.14

https://github.com/containers/podman/blob/60e0ef3e0d511d0250f6a988ff44deb0dfb73b6a/contrib/win-installer/build.ps1#L102

[packit-as-a-service[bot]]

Cockpit tests failed for commit f6f45e902f2f34d7d4360d184f3e3d861c0708bb. @martinpitt, @jelly, @mvollmer please check.

[lsm5]

The wix version probably also needs to be updated here, as it looks like we're hardcoding WiX 3.14

https://github.com/containers/podman/blob/60e0ef3e0d511d0250f6a988ff44deb0dfb73b6a/contrib/win-installer/build.ps1#L102

@ashley-cui ugh, do you know if we can wildcard / skip it ? I'm hoping this way we can just use the version that dotnet installs and be done with it.

[packit-as-a-service[bot]]

Cockpit tests failed for commit 79506f986ae2697e7899b50b101f62fea7bc7a3f. @martinpitt, @jelly, @mvollmer please check.

[ashley-cui]

@lsm5 I haven't tinkered with it enough to know unfortunately :(

[packit-as-a-service[bot]]

Ephemeral COPR build failed. @containers/packit-build please check.

[packit-as-a-service[bot]]

Cockpit tests failed for commit 723ede25e4f6ce14868abd9381c1f0280e92dd50. @martinpitt, @jelly, @mvollmer please check.

[packit-as-a-service[bot]]

Cockpit tests failed for commit e7884f06dc80b1787cb5ed72ec98a08895fca4f1. @martinpitt, @jelly, @mvollmer please check.

[packit-as-a-service[bot]]

Ephemeral COPR build failed. @containers/packit-build please check.

[packit-as-a-service[bot]]

Failed to load packit config file:

Please correct data and retry.

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

[packit-as-a-service[bot]]

Failed to load packit config file:

Please correct data and retry.

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

[packit-as-a-service[bot]]

Failed to load packit config file:

Please correct data and retry.

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

[lsm5]

@cevich any idea why the Windows Cross task is failing? I updated the image SFX with what was generated in https://github.com/containers/automation_images/pull/354#issuecomment-2099070879

[packit-as-a-service[bot]]

Ephemeral COPR build failed. @containers/packit-build please check.

[packit-as-a-service[bot]]

Ephemeral COPR build failed. @containers/packit-build please check.

[lsm5]

igonre packit failures

[lsm5]

So, looks like build.ps1 should be good to go. CheckCommand wix ... works.

I need to now update contrib/win-installer/build-msi.bat and replace heat, candle and light with wix build. @l0rd is that something you were looking into already?

[l0rd]

No, I haven't looked at the migration to WiX 4/5 but I would expect changes to the wxs/xml files (the schemas have changed). And my PR that is currently under review has some changes to those files so, if possible, use my branch as the base for your work.

[lsm5]

@Luap99 do we need the machine label on this PR? It updates the windows installer and the windows build and release process. The label was added by github action almost 2 months ago, but I don't know if it's still relevant.

[Luap99]

@Luap99 do we need the machine label on this PR? It updates the windows installer and the windows build and release process. The label was added by github action almost 2 months ago, but I don't know if it's still relevant.

The label is set based on what file is changed by github action, I guess the action does't remove it again when someone repushes without machine changes?! It has nothing do with what CI runs so feel free to drop that label.

As you touch .cirrus.yml all test have to run no matter what.

[lsm5]

@ashley-cui @l0rd @n1hility @baude PTAL. cc @containers/podman-maintainers

[lsm5]

/hold

setting hold so that we merge https://github.com/containers/automation_images/pull/354 before merging this.

[lsm5]

LGTM I have been able to test different scenarios (with and without wsl/hyperv, setting/unsetting WSL/Hyper-V checkboxes) and it worked as expected.

I have pushed another commit with some minor improvements (mainly to the setup.exe GUI). I would like to include it in this PR but it can also be submitted as a separate one.

I'll include it here. Thanks!

[lsm5]

setting this back to draft to test out a change to windows image with simplified dotnet install.

[lsm5]

@l0rd windows jobs are passing with the latest version of https://github.com/containers/automation_images/pull/354 . PTAL again.

[lsm5]

looks like the machine-mac podman darwin rootless host sqlite test is failing on other PRs too. @Luap99 ok to ignore it or should we wait for a fix?

[Luap99]

looks like the machine-mac podman darwin rootless host sqlite test is failing on other PRs too. @Luap99 ok to ignore it or should we wait for a fix?

Unfortunately we have to re-run until it passes. And yes it took 12 tries on my PR :( I try to debug/fix this currently but it is more complex than thought: https://github.com/containers/podman/pull/23162

[lsm5]

@cevich do we need the optional release test on this PR?

[lsm5]

i'll need another run of this once the latest build of automation_images is done.