netavark
netavark copied to clipboard
test: Move firewalld tests into one file
Moving firewalld related tests into one file should be convenient for the user who doesn't care firewalld.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Mingli-Yu Once this PR has been reviewed and has the lgtm label, please assign jwhonce for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Ephemeral COPR build failed. @containers/packit-build please check.
ping.
Thanks!
@Mingli-Yu the tests are failing so there isn't much point for me to review this. It is up to you to fix that.
Also you have not fixed my earlier review comment with the $fw_driver in the test name which is not correct
@Luap99 Many thanks for your respond! I actually didn't fix any test cases right now, just try to group all firewalld related cases into one file. And latest PR did have the problem with the $fw_driver in the test name. Do you plan to group all firewalld related cases into one file? If yes, I will send a new PR then.
I don't have any plans in that regard. These are upstream tests that work for us. If others like to make them work in their environments and send PRs to do that is fine for me but I am not interesting in spending a bunch of time to get them work in every possible scenario.