netavark
netavark copied to clipboard
fix(deps): update rust crate ipnet to 2.10.0
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| ipnet | dependencies | minor | 2.9.0 -> 2.10.0 |
Release Notes
krisprice/ipnet (ipnet)
v2.10.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
- [ ] If you want to rebase/retry this PR, check this box
This PR was generated by Mend Renovate. View the repository job log.
Ephemeral COPR build failed. @containers/packit-build please check.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: lsm5, renovate[bot]
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [lsm5]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
rpmbuild failing with
*** ERROR: ./usr/src/debug/netavark-1.12.1-1.20240913132301490491.pr1078.39.gd0b1e8c.fc42.x86_64/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ipnet-2.10.0/src/lib.rs has shebang which doesn't start with '/' ([doc(html_root_url = "https://docs.rs/ipnet/2.10.0")])
rpmbuild failing with
*** ERROR: ./usr/src/debug/netavark-1.12.1-1.20240913132301490491.pr1078.39.gd0b1e8c.fc42.x86_64/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ipnet-2.10.0/src/lib.rs has shebang which doesn't start with '/' ([doc(html_root_url = "https://docs.rs/ipnet/2.10.0")])
@lsm5 Have you reported this somewhere to the rust/rpm packaging folks? AFAICT this line has been present in earlier versions as well so I don't understand why this update triggers it. In any case rust compiles fine so this is clearly something wrong with the rpm build process.
@lsm5 Have you reported this somewhere to the rust/rpm packaging folks? AFAICT this line has been present in earlier versions as well so I don't understand why this update triggers it. In any case rust compiles fine so this is clearly something wrong with the rpm build process.
Not yet. Let me rebase and see the latest.
Still failing
*** WARNING: ./usr/src/debug/netavark-1.12.1-1.20240927105617062255.pr1078.42.g2d6535b.fc41.aarch64/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ipnet-2.10.0/src/parser.rs is executable but has no shebang, removing executable bit
*** WARNING: ./usr/src/debug/netavark-1.12.1-1.20240927105617062255.pr1078.42.g2d6535b.fc41.aarch64/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ipnet-2.10.0/src/mask.rs is executable but has no shebang, removing executable bit
*** ERROR: ./usr/src/debug/netavark-1.12.1-1.20240927105617062255.pr1078.42.g2d6535b.fc41.aarch64/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ipnet-2.10.0/src/lib.rs has shebang which doesn't start with '/' ([doc(html_root_url = "https://docs.rs/ipnet/2.10.0")])
*** WARNING: ./usr/src/debug/netavark-1.12.1-1.20240927105617062255.pr1078.42.g2d6535b.fc41.aarch64/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ipnet-2.10.0/src/ipnet_serde.rs is executable but has no shebang, removing executable bit
*** WARNING: ./usr/src/debug/netavark-1.12.1-1.20240927105617062255.pr1078.42.g2d6535b.fc41.aarch64/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ipnet-2.10.0/src/ipnet.rs is executable but has no shebang, removing executable bit
*** WARNING: ./usr/src/debug/netavark-1.12.1-1.20240927105617062255.pr1078.42.g2d6535b.fc41.aarch64/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ipnet-2.10.0/src/ipext.rs is executable but has no shebang, removing executable bit
Something did a chmod +x on the files it seems bu I am unsure how this happened. It is not in the upstream git repository only in the cargo crates repo.
$ ls -l ~/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ipnet-2.10.0/src
total 136
-rwxr-xr-x. 1 pholzing pholzing 32015 Jul 24 2006 ipext.rs
-rwxr-xr-x. 1 pholzing pholzing 62841 Jul 24 2006 ipnet.rs
-rwxr-xr-x. 1 pholzing pholzing 3529 Jul 24 2006 ipnet_schemars.rs
-rwxr-xr-x. 1 pholzing pholzing 9535 Jul 24 2006 ipnet_serde.rs
-rwxr-xr-x. 1 pholzing pholzing 4474 Jul 24 2006 lib.rs
-rwxr-xr-x. 1 pholzing pholzing 3915 Jul 24 2006 mask.rs
-rwxr-xr-x. 1 pholzing pholzing 11122 Jul 24 2006 parser.rs
$ ls -l ~/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ipnet-2.9.0/src/
total 132
-rw-r--r--. 1 pholzing pholzing 32015 Jul 24 2006 ipext.rs
-rw-r--r--. 1 pholzing pholzing 58001 Jul 24 2006 ipnet.rs
-rw-r--r--. 1 pholzing pholzing 3529 Jul 24 2006 ipnet_schemars.rs
-rw-r--r--. 1 pholzing pholzing 9535 Jul 24 2006 ipnet_serde.rs
-rw-r--r--. 1 pholzing pholzing 4473 Jul 24 2006 lib.rs
-rw-r--r--. 1 pholzing pholzing 3915 Jul 24 2006 mask.rs
-rw-r--r--. 1 pholzing pholzing 11122 Jul 24 2006 parser.rs
So something on crates.io causes them to be executable?
And it seem the rpm debuginfo builds do not like to have files executable when they are not actually executable.
@Luap99 have you seen similar error on any other crate update?
@Luap99 have you seen similar error on any other crate update?
No this is the first we see this
Looking at the non vendored rust packages in fedora they all still seem to be at 2.9 as well, not sure if they just haven't been updated yet or if they also encounter this issue there. https://src.fedoraproject.org/rpms/rust-ipnet
/lgtm
For reference the executable bits were fixed in 2.10.1 https://github.com/krisprice/ipnet/issues/59 so this now works fine in the rpm builds
/hold cancel