netavark icon indicating copy to clipboard operation
netavark copied to clipboard

aardvark-dns: trim whitespaces from error text

Open Luap99 opened this issue 1 year ago • 3 comments

Noticed this while testing my aardvark-dns changes. As we capture the full stderr it includes the final newline from the error text which will then be returned like this to podman. However because all podman always adds a newline to its error output on the cli it resulted in two newlines being printed. Not a bug deal but still unnecessary and confusing.

Luap99 avatar Jul 26 '24 11:07 Luap99

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jul 26 '24 11:07 openshift-ci[bot]

@mheon @baude PTAL

Luap99 avatar Jul 30 '24 14:07 Luap99

Sure, LGTM

mheon avatar Jul 30 '24 14:07 mheon

/lgtm

baude avatar Jul 31 '24 16:07 baude