netavark
netavark copied to clipboard
containers
Cirrus: remove centos9 build job
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: lsm5, Luap99
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [Luap99,lsm5]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
i've begun talks with the go maintainers for centos stream about adding reverse dependency tests on golang rpms before they enter centos stream build environments. So, we should be able to block on packit tasks sometime soon.
I have not looked at enough to errors to tell but I don't see how blocking golang rpms is helping us here. There are packit/tmt/whatever flakes in this pipeline, i.e. https://github.com/containers/netavark/pull/1016#issuecomment-2197897267, random dnf install failures at runtime, etc...
And our tests contain flakes too of course so the total number of flakes perceived by me looks high. Of course I have no tool to measure the actual numbers.
I have not looked at enough to errors to tell but I don't see how blocking golang rpms is helping us here. There are packit/tmt/whatever flakes in this pipeline, i.e. #1016 (comment), random dnf install failures at runtime, etc...
uh ya, sorry i meant along with golang, I have plans to check with rust maintainers as well
RE: flakes on that PR, I'll report those to packit.
RE: dnf install failures, please let me know next time you see them. Quite likely something can be done to fix issues in COPR or how we install packages.
RE: dnf install failures, please let me know next time you see them
There are permanently broken on aardvark-dns rawhide currently as an example, https://artifacts.dev.testing-farm.io/d4eac9f2-f05c-4585-8324-0e29a55ed479/ I assume you are already aware of this. Note I am overall in favor to expand packit/tmt test on aardvark/netavark repos but we cannot setup merge protection for these tasks if we have to to overwrite them to often. And without merge protection we may merge broken changes as most of us are used to ignore the packit/tmt jobs entirely.
RE: dnf install failures, please let me know next time you see them
There are permanently broken on aardvark-dns rawhide currently as an example, https://artifacts.dev.testing-farm.io/d4eac9f2-f05c-4585-8324-0e29a55ed479/ I assume you are already aware of this.
Yes, I've learned a few things since the last change to aardvark-dns PR. Things have been fixed in container-selinux to account for this and I'll be replicating that to aardvark-dns.
Note I am overall in favor to expand packit/tmt test on aardvark/netavark repos but we cannot setup merge protection for these tasks if we have to to overwrite them to often. And without merge protection we may merge broken changes as most of us are used to ignore the packit/tmt jobs entirely.
About merge protection, we'll have to start somewhere. I'll start on container-selinux right away, and soon as we have revdep testing on golang and rust, we can start blocking on build jobs (and later on test jobs) on other repos.
