conmon-rs
conmon-rs copied to clipboard
Add streaming server
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adding streaming server support.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Refers to https://github.com/cri-o/cri-o/issues/7826
Does this PR introduce a user-facing change?
Added streaming server support.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: saschagrunert
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [saschagrunert]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 68.57143% with 33 lines in your changes missing coverage. Please review.
Project coverage is 63.18%. Comparing base (
4e0f474) to head (55d9319). Report is 740 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## main #2070 +/- ##
===========================================
+ Coverage 37.53% 63.18% +25.64%
===========================================
Files 15 127 +112
Lines 1268 4520 +3252
Branches 414 898 +484
===========================================
+ Hits 476 2856 +2380
- Misses 526 1664 +1138
+ Partials 266 0 -266
+1 to axum. Can we use a domain socket instead of a tcp socket?
+1 to axum. Can we use a domain socket instead of a tcp socket?
I have to check if Kubernetes supports that, but generally yes :+1:
+1 to axum. Can we use a domain socket instead of a tcp socket?
No, it's currently not due to: https://github.com/kubernetes/client-go/blob/1518fca9f06c6a73fc091535b8966c71704e657b/transport/websocket/roundtripper.go#L109
@haircommander @rphillips PTAL. This is now ready.
@rphillips @haircommander PTAL
@haircommander @rphillips PTAL
@rphillips @haircommander PTAL
@kwilczynski @haircommander PTAL, shall we get this in?
@kwilczynski @haircommander PTAL, shall we get this in?
@saschagrunert, let me have a quick review, if you don't mind. :smile:
Rebased
/hold
So that I can make a review.