conmon-rs icon indicating copy to clipboard operation
conmon-rs copied to clipboard

Add streaming server

Open saschagrunert opened this issue 1 year ago • 14 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adding streaming server support.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Refers to https://github.com/cri-o/cri-o/issues/7826

Does this PR introduce a user-facing change?

Added streaming server support.

saschagrunert avatar Mar 18 '24 14:03 saschagrunert

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Mar 18 '24 14:03 openshift-ci[bot]

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 68.57143% with 33 lines in your changes missing coverage. Please review.

Project coverage is 63.18%. Comparing base (4e0f474) to head (55d9319). Report is 740 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2070       +/-   ##
===========================================
+ Coverage   37.53%   63.18%   +25.64%     
===========================================
  Files          15      127      +112     
  Lines        1268     4520     +3252     
  Branches      414      898      +484     
===========================================
+ Hits          476     2856     +2380     
- Misses        526     1664     +1138     
+ Partials      266        0      -266     

codecov-commenter avatar Mar 18 '24 14:03 codecov-commenter

+1 to axum. Can we use a domain socket instead of a tcp socket?

rphillips avatar Mar 18 '24 14:03 rphillips

+1 to axum. Can we use a domain socket instead of a tcp socket?

I have to check if Kubernetes supports that, but generally yes :+1:

saschagrunert avatar Mar 18 '24 16:03 saschagrunert

+1 to axum. Can we use a domain socket instead of a tcp socket?

No, it's currently not due to: https://github.com/kubernetes/client-go/blob/1518fca9f06c6a73fc091535b8966c71704e657b/transport/websocket/roundtripper.go#L109

saschagrunert avatar Mar 20 '24 10:03 saschagrunert

@haircommander @rphillips PTAL. This is now ready.

saschagrunert avatar Mar 21 '24 16:03 saschagrunert

@rphillips @haircommander PTAL

saschagrunert avatar Mar 25 '24 20:03 saschagrunert

@haircommander @rphillips PTAL

saschagrunert avatar Apr 02 '24 07:04 saschagrunert

@rphillips @haircommander PTAL

saschagrunert avatar Apr 23 '24 08:04 saschagrunert

@kwilczynski @haircommander PTAL, shall we get this in?

saschagrunert avatar Sep 03 '24 12:09 saschagrunert

@kwilczynski @haircommander PTAL, shall we get this in?

@saschagrunert, let me have a quick review, if you don't mind. :smile:

kwilczynski avatar Sep 03 '24 12:09 kwilczynski

Rebased

saschagrunert avatar Sep 11 '24 07:09 saschagrunert

/hold

So that I can make a review.

kwilczynski avatar Oct 03 '24 08:10 kwilczynski