buildah icon indicating copy to clipboard operation
buildah copied to clipboard

Published 20 hours ago • verified publisher icon containers

RUN: only use an overlay for --mount=type=bind,rw on overlay

Open nalind opened this issue 7 months ago • 3 comments

What type of PR is this?

/kind bug

What this PR does / why we need it:

Only use an overlay for --mounts of type=bind,rw, where changes should be discarded, if the storage driver is overlay. Otherwise, make a temporary copy.

How to verify it

Updated CI to test {vfs|overlay} over {vfs|overlay}, which would have caught this.

Which issue(s) this PR fixes:

Should fix #5988.

Special notes for your reviewer:

Basically what https://github.com/containers/buildah/issues/5988#issuecomment-2718307144 suggested.

Does this PR introduce a user-facing change?

When not using overlay for storage, running `buildah run` or executing a `buildah build` RUN instruction with the `--mount=type=bind,rw` flag will now use a temporary copy to ensure that writes are discarded, instead of attempting to mount an overlay filesystem using the source location as a "lower".

nalind avatar Apr 15 '25 21:04 nalind

Ephemeral COPR build failed. @containers/packit-build please check.

packit-as-a-service[bot] avatar Apr 17 '25 18:04 packit-as-a-service[bot]

@nalind looks lke you need an update here.

TomSweeneyRedHat avatar Jun 04 '25 19:06 TomSweeneyRedHat

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Honny1, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jun 05 '25 12:06 openshift-ci[bot]

A friendly reminder that this PR had no activity for 30 days.

github-actions[bot] avatar Jul 07 '25 00:07 github-actions[bot]

@nalind merge conflict here that needs some massaging.

TomSweeneyRedHat avatar Jul 10 '25 20:07 TomSweeneyRedHat

A friendly reminder that this PR had no activity for 30 days.

github-actions[bot] avatar Aug 10 '25 00:08 github-actions[bot]

What's the status of this PR? It was approved at some point and then seemingly abandoned.

We run into the same problem in our CI and are interested in a solution to the problem, are there any plans to get this PR back on track in the near future?

Vince-FIS avatar Oct 01 '25 11:10 Vince-FIS