buildah icon indicating copy to clipboard operation
buildah copied to clipboard

[WIP] Support nvidia.com/gpus as devices

Open rhatdan opened this issue 1 year ago • 5 comments

What type of PR is this?

/kind api-change /kind bug /kind cleanup /kind deprecation /kind design /kind documentation /kind failing-test /kind feature /kind flake /kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

buildah now supports nvidia/gpus options for devices.

rhatdan avatar Jul 29 '24 11:07 rhatdan

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jul 29 '24 11:07 openshift-ci[bot]

Is this about #5227?

nalind avatar Aug 07 '24 18:08 nalind

Yes

rhatdan avatar Aug 09 '24 10:08 rhatdan

Then, if the answer to https://github.com/containers/buildah/issues/5227#issuecomment-2269878679 ends up being "the CDI configuration wasn't provided to the container", there may not be anything needed here beyond updating to 1.36, which was the first version that even recognized CDI device specs.

nalind avatar Aug 09 '24 13:08 nalind

A friendly reminder that this PR had no activity for 30 days.

github-actions[bot] avatar Sep 09 '24 00:09 github-actions[bot]