buildah icon indicating copy to clipboard operation
buildah copied to clipboard

install: On Debian/Ubuntu, add installation of libbtrfs-dev and libdevmapper-dev

Open jelmer opened this issue 1 year ago • 3 comments

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Adds missing build dependencies on Ubuntu/Debian; without this the build fails.

How to verify it

On a clean Debian install, run the specified command and then run "make" to build buildah.

install.md: Add missing build dependencies (libdevmapper-dev, libbtrfs-dev) on Debian/Ubuntu

jelmer avatar May 23 '24 10:05 jelmer

A friendly reminder that this PR had no activity for 30 days.

github-actions[bot] avatar Jun 23 '24 00:06 github-actions[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, jelmer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jul 01 '24 18:07 openshift-ci[bot]

The btrfs storage driver should be enabled if it's detected (or rather, if its absence is not detected) at build-time, and this would help ensure that it is found.

Whether or not libdevmapper-dev is installed has been steeadfastly ignored since 1.31 and #4832, so including it on the list of packages to install won't change the set of build tags which the Makefile chooses to use in that version or any later version. Any underlying support that might have been enabled was removed outright for 1.36 in #5539.

nalind avatar Jul 01 '24 18:07 nalind

Remove libdevmapper since this is no longer supported.

rhatdan avatar Jul 17 '24 12:07 rhatdan

Updated to drop libdebmapper-dev.

jelmer avatar Aug 05 '24 10:08 jelmer

/lgtm

nalind avatar Aug 05 '24 20:08 nalind

/override "Debian Conformance w/ vfs"

nalind avatar Aug 06 '24 19:08 nalind

@nalind: Overrode contexts on behalf of nalind: Debian Conformance w/ vfs

In response to this:

/override "Debian Conformance w/ vfs"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Aug 06 '24 19:08 openshift-ci[bot]