buildah icon indicating copy to clipboard operation
buildah copied to clipboard

fix(deps): fix test/tools ginkgo typo

Open Asutorufa opened this issue 1 year ago • 2 comments

What type of PR is this?

/kind bug

What this PR does / why we need it:

tests/tools/tools.go import wrong ginkgo package name

How to verify it

$ cd tests/tools
$ go mod tidy
go: finding module for package github.com/onsi/ginkgo/ginkgo/v2
go: github.com/containers/buildah/tests/tools imports
	github.com/onsi/ginkgo/ginkgo/v2: module github.com/onsi/ginkgo@latest found (v1.16.5), but does not contain package github.com/onsi/ginkgo/ginkgo/v2

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Asutorufa avatar Apr 03 '24 09:04 Asutorufa

A friendly reminder that this PR had no activity for 30 days.

github-actions[bot] avatar May 04 '24 00:05 github-actions[bot]

Ah, thanks for catching this! Any chance I can get you to rebase and use git commit --amend -s to add a Signed-off-by: to the log message for your commit? That should appease the DCO test in CI.

nalind avatar Aug 05 '24 20:08 nalind

@nalind Thanks for you review, please check again.

Asutorufa avatar Aug 06 '24 05:08 Asutorufa

Tests passed, looks good. Thanks!

/approve /lgtm

nalind avatar Aug 06 '24 13:08 nalind

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Asutorufa, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 06 '24 13:08 openshift-ci[bot]