buildah icon indicating copy to clipboard operation
buildah copied to clipboard

Published 20 hours ago • verified publisher icon containers

`CONTRIBUTING.md`: Update contact information

Open AndASM opened this issue 3 years ago • 2 comments

What type of PR is this?

/kind documentation

What this PR does / why we need it:

CONTRIBUTING.md is outdated. New contributors will be directed to a dead freenode channel.

Changes:

  • Freenode is no longer used, IRC has moved to libera.chat.
  • [matrix] is federated into the #podman channel and can be used instead of IRC.

How to verify it

Read CONTRIBUTING.md.

Which issue(s) this PR fixes:

Fixes #4308

Special notes for your reviewer:

I am assuming this counts as "developer-facing" not "user-facing" so I have put None under the release notes. Is that correct?

Does this PR introduce a user-facing change?

None

AndASM avatar Oct 03 '22 20:10 AndASM

LGTM @TomSweeneyRedHat PTAL

rhatdan avatar Oct 04 '22 10:10 rhatdan

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndASM Once this PR has been reviewed and has the lgtm label, please assign cevich for approval by writing /assign @cevich in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 17 '22 12:10 openshift-ci[bot]

@AndASM Are you still working on this, or would you rather us finish it?

rhatdan avatar Oct 17 '22 12:10 rhatdan

@AndASM Are you still working on this, or would you rather us finish it?

Sorry about that, I missed the update emails and have been distracted and busy lately. I'll try to take a look tomorrow if you haven't otherwise taken care of it.

AndASM avatar Oct 18 '22 02:10 AndASM

Oops it was commit 2c06b50cf1635f1504bf83a19fb414a6f8bc99c5 caused by using github rebase , @AndASM Could you squash commits into one ?

flouthoc avatar Oct 18 '22 03:10 flouthoc

@AndASM Are you still working on this one?

rhatdan avatar Nov 01 '22 13:11 rhatdan

A friendly reminder that this PR had no activity for 30 days.

github-actions[bot] avatar Dec 02 '22 00:12 github-actions[bot]

Oops, sorry about that! Life has been a bit crazy of late.

I squashed the commits into one, and rebased it on the current main branch. Is this still okay to pull? It might help someone to have those updates to the documentation. @rhatdan?

AndASM avatar Dec 02 '22 21:12 AndASM

I can't seem to reopen, could you open a new PR with just one commit.

rhatdan avatar Dec 04 '22 22:12 rhatdan