buildah WIP DO NOT MERGE - Make stderr red color

When an error is thrown inside the container, like one from ls /fakefile, the return string should be colored red when doing a bud or run action. Currently it's coming black as red.

Addresses Bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=1661593

Signed-off-by: TomSweeneyRedHat [email protected]

What type of PR is this?

/kind api-change /kind bug /kind cleanup /kind deprecation /kind design /kind documentation /kind failing-test /kind feature /kind flake /kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Sep 01 '20 23:09 TomSweeneyRedHat

I've put this PR up mostly so I can more easily ask @nalind some questions.

Sep 01 '20 23:09 TomSweeneyRedHat

Are we just going to give up on this one?

Oct 28 '20 19:10 rhatdan

@TomSweeneyRedHat Nalin and I talked about this yesterday and came to the agreement to remove the pseudo-terminal from buildah bud for the remote commands. This should allow us to separate the stdin from stdout, and then you could add your magic to make stderr red. When doing buildah run, the pseudo-terminal would continue to be used, so the red stderr, would be disabled, which I believe is the correct behaviour.

We have eliminated stdin from buildah bud already so there is no interaction between the users terminal and the build session.

Could you start working on this PR again to see if removing the pseudo terminal makes it work?

Oct 30 '20 09:10 rhatdan

@rhatdan sure thing, I'll give it a go.

Oct 30 '20 17:10 TomSweeneyRedHat