aardvark-dns icon indicating copy to clipboard operation
aardvark-dns copied to clipboard

[skip-ci] TMT: Minimize distro conditionals

Open lsm5 opened this issue 1 year ago • 13 comments
trafficstars

This commit accounts for breaking changes in dnf5 config-manager.

Merge after https://github.com/containers/aardvark-dns/pull/461

lsm5 avatar May 15 '24 14:05 lsm5

Ephemeral COPR build failed. @containers/packit-build please check.

@mheon @Luap99 PTAL

lsm5 avatar May 15 '24 17:05 lsm5

Integration tests failed. @containers/packit-build please check.

Ephemeral COPR build failed. @containers/packit-build please check.

Integration tests failed. @containers/packit-build please check.

Ephemeral COPR build failed. @containers/packit-build please check.

Integration tests failed. @containers/packit-build please check.

Ephemeral COPR build failed. @containers/packit-build please check.

I'll probably end up reworking this to also account for downstream reusability.

lsm5 avatar May 21 '24 15:05 lsm5

Tests failed. @containers/packit-build please check.

Tests failed. @containers/packit-build please check.

Tests failed. @containers/packit-build please check.

Ephemeral COPR build failed. @containers/packit-build please check.

/packit build

lsm5 avatar Jul 08 '24 18:07 lsm5

/packit rebuild-failed

lsm5 avatar Jul 08 '24 18:07 lsm5

Tests failed. @containers/packit-build please check.

Ephemeral COPR build failed. @containers/packit-build please check.

Tests failed. @containers/packit-build please check.

Ephemeral COPR build failed. @containers/packit-build please check.

Tests failed. @containers/packit-build please check.

Ephemeral COPR build failed. @containers/packit-build please check.

Tests failed. @containers/packit-build please check.

Ephemeral COPR build failed. @containers/packit-build please check.

Tests failed. @containers/packit-build please check.

Ephemeral COPR build failed. @containers/packit-build please check.

Tests failed. @containers/packit-build please check.

Ephemeral COPR build failed. @containers/packit-build please check.

@Luap99 @edsantiago @cevich PTAL at the current state. With this setup, we can reuse the tests for Fedora zuul (before dist-git PR merge) and bodhi updates and also on CentOS Stream.

See test downstream PR: https://src.fedoraproject.org/rpms/aardvark-dns/pull-request/20 and the actual TMT test trigger in Zuul: https://artifacts.dev.testing-farm.io/34dd8354-1a3d-4d34-ba58-9fb432581b8b/ .

Unit, validate and integration tests are run upstream while only the integration tests are run downstream.

Once everything looks ok, I'll re-enable failure notifications and repush for final merge.

lsm5 avatar Jul 11 '24 14:07 lsm5

PTAL again. Good for hopefully final review and merge. Thanks!

lsm5 avatar Jul 12 '24 14:07 lsm5

LGTM, I have no way to verify any of the downstream changes but looks like the upstream changes work and it is tested properly

Thanks @Luap99.

If anyone would like to verify how it looks like downstream (currently a manual sync), go to the dist-git test PR: https://src.fedoraproject.org/rpms/aardvark-dns/pull-request/20# -> Zuul CI result -> rpm-tmt-test -> Artifacts tab -> Testing Farm Artifacts. Only the downstream integration tests are run there.

The automatic syncing from Packit and bodhi results will only be found after an upstream release, unless we do a manual sync first. But Zuul results should be a strong enough indicator. HTH.

lsm5 avatar Jul 12 '24 18:07 lsm5