Packit: initial enablement

[lsm5]

trafficstars

This commit will run Koji scratch builds on every PR against all active releases of Fedora, thus allowing buildability checks before the PR merges.

Signed-off-by: Lokesh Mandvekar [email protected]

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [lsm5]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[lsm5]

https://github.com/containers/netavark/pull/399#issuecomment-1233365737 applies here too

[lsm5]

/packit copr-build

[Luap99]

@lsm5 Is this still needed?

[lsm5]

@lsm5 Is this still needed?

@Luap99 yes, hoping to get this going soon. keep this open. Thanks!

[packit-as-a-service[bot]]

Failed to load packit config file:

Cannot parse package config: ValidationError({'jobs': {0: {'packages': defaultdict(<class 'dict'>, {'aardvark-dns': {'value': {'additional_packages': ['Not a valid list.']}}})}}}).

For more info, please check out the documentation or contact the Packit team.

[packit-as-a-service[bot]]

Failed to load packit config file:

Cannot parse package config: ValidationError({'jobs': {0: {'packages': defaultdict(<class 'dict'>, {'aardvark-dns': {'value': {'targets': ["Expected 'list[str]' or 'dict[str,dict]', got [{'fedora-rawhide-aarch64': None, 'additional_packages': 'make'}, {'fedora-rawhide-x86_64': None, 'additional_packages': 'make'}] (type <class 'list'>)."]}}})}}}).

For more info, please check out the documentation or contact the Packit team.

[packit-as-a-service[bot]]

Failed to load packit config file:

Cannot parse package config: ValidationError({'jobs': {0: {'packages': defaultdict(<class 'dict'>, {'aardvark-dns': {'value': {'targets': ["Expected <class 'list'>, got 'make' (type <class 'str'>)"]}}})}}}).

For more info, please check out the documentation or contact the Packit team.

[packit-as-a-service[bot]]

Failed to load packit config file:

Cannot parse package config: ValidationError({'jobs': {0: {'packages': defaultdict(<class 'dict'>, {'aardvark-dns': {'value': {'targets': ["Expected 'list[str]' or 'dict[str,dict]', got {'fedora-rawhide': None} (type <class 'dict'>)."]}}})}}}).

For more info, please check out the documentation or contact the Packit team.

[packit-as-a-service[bot]]

Failed to load packit config file:

Cannot parse package config: ValidationError({'jobs': {0: {'packages': defaultdict(<class 'dict'>, {'aardvark-dns': {'value': {'targets': ["Expected <class 'list'>, got 'make' (type <class 'str'>)"]}}})}}}).

For more info, please check out the documentation or contact the Packit team.

[packit-as-a-service[bot]]

Failed to load packit config file:

Cannot parse package config: ValidationError({'jobs': {0: {'packages': defaultdict(<class 'dict'>, {'aardvark-dns': {'value': {'targets': ["Expected <class 'list'>, got 'make,openssl-devel' (type <class 'str'>)"]}}})}}}).

For more info, please check out the documentation or contact the Packit team.

[lsm5]

@edsantiago @cevich wdyt?

The copr build url is at: https://copr.fedorainfracloud.org/coprs/packit/containers-aardvark-dns-214/build/5433851/ . The package NVR lists the PR # as well as the head commit id in the release field.

We should be able to add centos stream as well if you're cool with proceeding.

[lsm5]

This PR depends on https://github.com/containers/aardvark-dns/pull/288 .

[lsm5]

Most packit builds seem to complete within the total time required by the cirrus tests, so hopefully that should not be a blocker.

[Luap99]

Most packit builds seem to complete within the total time required by the cirrus tests, so hopefully that should not be a blocker.

Assuming that this helps to catch bugs like https://github.com/containers/netavark/issues/578 early I think it is worth it even if it takes longer.

[packit-as-a-service[bot]]

We have requested the builder permissions for the rhcontainerbot/packit-builds Copr project.

Please confirm the request on the rhcontainerbot/packit-builds Copr project permissions page and retrigger the build by a /packit build pull-request comment or click on a Re-run button.

[lsm5]

/packit build

[lsm5]

hmm, dunno why custom copr project is taking so long.

[cevich]

The script and YAML LGTM, with only a few nits. I can't review the system as a whole because I'm packaging-dumb :grin:

[lsm5]

depends on https://github.com/containers/aardvark-dns/pull/290

[lsm5]

disabled fedora-36-armhfp from the copr build targets as the builds are failing weirdly and I honestly don't think it's worth the effort as fedora 36 is lower priority and will soon go EOL. I've left a TODO on the copr homepage regardless.

[lsm5]

@Luap99 @cevich @edsantiago PTAL again. Good to go, I hope.

[lsm5]

@cevich if you're happy with this, maybe we can remove the centos9_build cirrus task. wdyt?

[edsantiago]

OIC, the Makefile/CARGO commit was #290, which merged, which is why the commit disappeared. That took me way too long to figure out.

LGTM, with the caveat that I don't grok Packit. My quibble are minor:

• "Fix X" comments aren't really helpful, they'd be more useful if they said something like "Version derived from Cargo", "PACKIT_RPMSPEC_RELEASE" is given to us by packit, see http/foo", "Source0 is the tarball we generated above", etc. Basically, comments should say something that isn't obvious from the code itself. Not worth repushing for though.

[lsm5]

• "Fix X" comments aren't really helpful, they'd be more useful if they said something like "Version derived from Cargo", "PACKIT_RPMSPEC_RELEASE" is given to us by packit, see http/foo", "Source0 is the tarball we generated above", etc. Basically, comments should say something that isn't obvious from the code itself. Not worth repushing for though.

I'm happy to push again.

[edsantiago]

Nah - the build is passing. Not worth it unless @cevich finds other concerns.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, edsantiago, lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [edsantiago,lsm5]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[Luap99]

Lets get this in. /hold cancel