nri icon indicating copy to clipboard operation
nri copied to clipboard

Support standard golang compiler for WASM plugins

Open saschagrunert opened this issue 9 months ago • 6 comments
trafficstars

Tracking a feature for supporting the standard golang compiler (big go) for WASM plugins.

Refers to https://github.com/knqyf263/go-plugin/issues/58#issuecomment-2558130178

saschagrunert avatar Feb 04 '25 07:02 saschagrunert

This change is required which will land in go 1.24.

saschagrunert avatar Feb 06 '25 10:02 saschagrunert

Looks like https://github.com/knqyf263/go-plugin/pull/71 does the trick.

saschagrunert avatar Mar 10 '25 10:03 saschagrunert

I merged https://github.com/knqyf263/go-plugin/pull/71. It would be appreciated if you can test it. Once we confirm it works, I'll cut a new version of go-plugin.

knqyf263 avatar Mar 11 '25 05:03 knqyf263

I tested it with CRI-O and https://github.com/containerd/nri/pull/148 and it does not seem to be able to load the plugin:

INFO[2025-03-11T14:24:52.57275786+01:00] Found WASM plugin: /opt/nri/plugins/10-wasm   file="adaptation/plugin.go:106"
WARN[2025-03-11T14:24:53.989058924+01:00] failed to start pre-installed NRI plugin "wasm": failed to configure plugin: wasm error: unreachable
wasm stack trace:
        .runtime.abort(i32) i32
        .runtime.fatalpanic(i32) i32
        .runtime.gopanic(i32) i32
        .runtime.sigpanic(i32) i32
        .github.com_containerd_nri_pkg_api._plugin_configure(i32) i32
        .plugin_configure(i32,i32) i64  file="adaptation/adaptation.go:396"

saschagrunert avatar Mar 11 '25 13:03 saschagrunert

What command did you run? I'm not familiar with NRI. I have no idea how I can test it.

knqyf263 avatar Mar 11 '25 16:03 knqyf263

I think I figured it out. https://github.com/containerd/nri/pull/148#issuecomment-2715104170

knqyf263 avatar Mar 11 '25 17:03 knqyf263

May I ask when we expect v1.0 (or an intermediate tag) to be released? 🙃

saschagrunert avatar Jul 08 '25 13:07 saschagrunert

intermediate very soon I think

mikebrow avatar Jul 08 '25 13:07 mikebrow