nerdctl icon indicating copy to clipboard operation
nerdctl copied to clipboard

FIX-1811: CI: test-integration often hits the 30min limit

Open amarlearning opened this issue 2 years ago • 5 comments

Fixes: #1811

  • Parallelize the TestIPFSComposeUp since it was taking ~300 sec to run.

amarlearning avatar Jan 12 '23 12:01 amarlearning

=== Failed
=== FAIL: github.com/containerd/nerdctl/cmd/nerdctl TestIPFSComposeUp/stargz (196.47s)
    compose_up_linux_test.go:79: projectName="nerdctl-compose-test1591673175"
    compose_up_linux_test.go:81: assertion failed: res.ExitCode is not exitCode: time="2023-01-12T13:27:21Z" level=info msg="Creating network nerdctl-compose-test1591673175_default"
        time="2023-01-12T13:27:22Z" level=info msg="Creating volume nerdctl-compose-test1591673175_wordpress"
        time="2023-01-12T13:27:22Z" level=info msg="Creating volume nerdctl-compose-test1591673175_db"
        time="2023-01-12T13:27:22Z" level=info msg="Ensuring image ipfs://bafkreieotogfr4robvzd5qi3ocotvluh3czyflhmgtfte5e5oz2ez3jdoi"
        bafkreieotogfr4robvzd5qi3ocotvluh3czyflhmgtfte5e5oz2ez3jdoi:                   resolved       |++++++++++++++++++++++++++++++++++++++| 
        index-sha256:9213db28c508afe306c1d12e3d626f57c0aff1b1b603ef84c0967d668de91eae: downloading    |--------------------------------------|    0.0 B/368.0 B 
        elapsed: 0.1 s                                                                 total:   0.0 B (0.0 B/s)                                         
        bafkreieotogfr4robvzd5qi3ocotvluh3czyflhmgtfte5e5oz2ez3jdoi:                      resolved       |++++++++++++++++++++++++++++++++++++++| 
        index-sha256:9213db28c508afe306c1d12e3d626f57c0aff1b1b603ef84c0967d668de91eae:    done           |++++++++++++++++++++++++++++++++++++++| 
        manifest-sha256:7e4244431b60d1a1070bc2c79bd367f7f1baee21c7aff2004e9d87f565c388b2: done           |++++++++++++++++++++++++++++++++++++++| 
        config-sha256:8a108343ee2f3ca2300a00cf60e7c376542e43ef40e472c4d18fbfc81c2561be:   downloading    |--------------------------------------|    0.0 B/17.5 KiB 
        elapsed: 0.2 s                                                                    total:  9.3 Ki (45.7 KiB/s)                                      
        bafkreieotogfr4robvzd5qi3ocotvluh3czyflhmgtfte5e5oz2ez3jdoi:                      resolved       |++++++++++++++++++++++++++++++++++++++| 
        index-sha256:9213db28c508afe306c1d12e3d626f57c0aff1b1b603ef84c0967d668de91eae:    done           |++++++++++++++++++++++++++++++++++++++| 
        manifest-sha256:7e4244431b60d1a1070bc2c79bd367f7f1baee21c7aff2004e9d87f565c388b2: done           |++++++++++++++++++++++++++++++++++++++| 
        config-sha256:8a108343ee2f3ca2300a00cf60e7c376542e43ef40e472c4d18fbfc81c2561be:   done           |++++++++++++++++++++++++++++++++++++++| 
        elapsed: 0.3 s                                                                    total:  26.8 K (88.8 KiB/s)                                      
        bafkreieotogfr4robvzd5qi3ocotvluh3czyflhmgtfte5e5oz2ez3jdoi:                      resolved       |++++++++++++++++++++++++++++++++++++++| 
        index-sha256:9213db28c508afe306c1d12e3d626f57c0aff1b1b603ef84c0967d668de91eae:    done           |++++++++++++++++++++++++++++++++++++++| 
        manifest-sha256:7e4244431b60d1a1070bc2c79bd367f7f1baee21c7aff2004e9d87f565c388b2: done           |++++++++++++++++++++++++++++++++++++++| 
        config-sha256:8a108343ee2f3ca2300a00cf60e7c376542e43ef40e472c4d18fbfc81c2561be:   done           |++++++++++++++++++++++++++++++++++++++| 
        elapsed: 0.4 s                                                                    total:  26.8 K (66.7 KiB/s)                                      
        bafkreieotogfr4robvzd5qi3ocotvluh3czyflhmgtfte5e5oz2ez3jdoi:                      resolved       |++++++++++++++++++++++++++++++++++++++| 
        index-sha256:9213db28c508afe306c1d12e3d626f57c0aff1b1b603ef84c0967d668de91eae:    done           |++++++++++++++++++++++++++++++++++++++| 
        manifest-sha256:7e4244431b60d1a1070bc2c79bd367f7f1baee21c7aff2004e9d87f565c388b2: done           |++++++++++++++++++++++++++++++++++++++| 
        config-sha256:8a108343ee2f3ca2300a00cf60e7c376542e43ef40e472c4d18fbfc81c2561be:   done           |++++++++++++++++++++++++++++++++++++++| 
        elapsed: 0.5 s                                                                    total:  26.8 K (53.4 KiB/s)                                      
        bafkreieotogfr4robvzd5qi3ocotvluh3czyflhmgtfte5e5oz2ez3jdoi:                      resolved       |++++++++++++++++++++++++++++++++++++++| 
        index-sha256:9213db28c508afe306c1d12e3d626f57c0aff1b1b603ef84c0967d668de91eae:    done           |++++++++++++++++++++++++++++++++++++++| 
        manifest-sha256:7e4244431b60d1a1070bc2c79bd367f7f1baee21c7aff2004e9d87f565c388b2: done           |++++++++++++++++++++++++++++++++++++++| 
        config-sha256:8a108343ee2f3ca2300a00cf60e7c376542e43ef40e472c4d18fbfc81c2561be:   done           |++++++++++++++++++++++++++++++++++++++| 
        elapsed: 0.6 s                                                                    total:  26.8 K (44.6 KiB/s)                                      
        bafkreieotogfr4robvzd5qi3ocotvluh3czyflhmgtfte5e5oz2ez3jdoi:                      resolved       |++++++++++++++++++++++++++++++++++++++| 
        index-sha256:9213db28c508afe306c1d12e3d626f57c0aff1b1b603ef84c0967d668de91eae:    done           |++++++++++++++++++++++++++++++++++++++| 
        manifest-sha256:7e4244431b60d1a1070bc2c79bd367f7f1baee21c7aff2004e9d87f565c388b2: done           |++++++++++++++++++++++++++++++++++++++| 
        config-sha256:8a108343ee2f3ca2300a00cf60e7c376542e43ef40e472c4d18fbfc81c2561be:   done           |++++++++++++++++++++++++++++++++++++++| 
        elapsed: 0.7 s                                                                    total:  26.8 K (38.1 KiB/s)                                      
        bafkreieotogfr4robvzd5qi3ocotvluh3czyflhmgtfte5e5oz2ez3jdoi:                      resolved       |++++++++++++++++++++++++++++++++++++++| 
        index-sha256:9213db28c508afe306c1d12e3d626f57c0aff1b1b603ef84c0967d668de91eae:    done           |++++++++++++++++++++++++++++++++++++++| 
        manifest-sha256:7e4244431b60d1a1070bc2c79bd367f7f1baee21c7aff2004e9d87f565c388b2: done           |++++++++++++++++++++++++++++++++++++++| 
        config-sha256:8a108343ee2f3ca2300a00cf60e7c376542e43ef40e472c4d18fbfc81c2561be:   done           |++++++++++++++++++++++++++++++++++++++| 
        elapsed: 0.8 s                                                                    total:  26.8 K (33.4 KiB/s)                                      
        time="2023-01-12T13:27:22Z" level=info msg="Ensuring image ipfs://bafkreib667i5icm2higgvzgoglesqyw2on4kbgraoa5qk2ubn722zwz4ri"
        bafkreib667i5icm2higgvzgoglesqyw2on4kbgraoa5qk2ubn722zwz4ri:                      resolved       |++++++++++++++++++++++++++++++++++++++| 
        index-sha256:ebdba499e9748fdb7d7a61e3d534af5ad2efa527775d8ce2b30dea866f192f10:    done           |++++++++++++++++++++++++++++++++++++++| 
        manifest-sha256:3cbbf403f9daf623e7db80db3e4d048c292ab61466fe18c715b39752c28835b2: downloading    |--------------------------------------|    0.0 B/5.2 KiB 
        elapsed: 0.1 s                                                                    total:  368.0  (3.5 KiB/s)                                       
        bafkreib667i5icm2higgvzgoglesqyw2on4kbgraoa5qk2ubn722zwz4ri:                      resolved       |++++++++++++++++++++++++++++++++++++++| 
        index-sha256:ebdba499e9748fdb7d7a61e3d534af5ad2efa527775d8ce2b30dea866f192f10:    done           |++++++++++++++++++++++++++++++++++++++| 
        manifest-sha256:3cbbf403f9daf623e7db80db3e4d048c292ab61466fe18c715b39752c28835b2: done           |++++++++++++++++++++++++++++++++++++++| 
        config-sha256:1f4036e6cda2bd575617d4204bbaeba9999a07c009fae6692ef307c0389c549f:   done           |++++++++++++++++++++++++++++++++++++++| 
        elapsed: 0.2 s                                                                    total:  14.5 K (71.8 KiB/s)                                      
        bafkreib667i5icm2higgvzgoglesqyw2on4kbgraoa5qk2ubn722zwz4ri:                      resolved       |++++++++++++++++++++++++++++++++++++++| 
        index-sha256:ebdba499e9748fdb7d7a61e3d534af5ad2efa527775d8ce2b30dea866f192f10:    done           |++++++++++++++++++++++++++++++++++++++| 
        manifest-sha256:3cbbf403f9daf623e7db80db3e4d048c292ab61466fe18c715b39752c28835b2: done           |++++++++++++++++++++++++++++++++++++++| 
        config-sha256:1f4036e6cda2bd575617d4204bbaeba9999a07c009fae6692ef307c0389c549f:   done           |++++++++++++++++++++++++++++++++++++++| 
        elapsed: 0.3 s                                                                    total:  14.5 K (47.9 KiB/s)                                      
        bafkreib667i5icm2higgvzgoglesqyw2on4kbgraoa5qk2ubn722zwz4ri:                      resolved       |++++++++++++++++++++++++++++++++++++++| 
        index-sha256:ebdba499e9748fdb7d7a61e3d534af5ad2efa527775d8ce2b30dea866f192f10:    done           |++++++++++++++++++++++++++++++++++++++| 
        manifest-sha256:3cbbf403f9daf623e7db80db3e4d048c292ab61466fe18c715b39752c28835b2: done           |++++++++++++++++++++++++++++++++++++++| 
        config-sha256:1f4036e6cda2bd575617d4204bbaeba9999a07c009fae6692ef307c0389c549f:   done           |++++++++++++++++++++++++++++++++++++++| 
        elapsed: 0.4 s                                                                    total:  14.5 K (36.0 KiB/s)                                      
        bafkreib667i5icm2higgvzgoglesqyw2on4kbgraoa5qk2ubn722zwz4ri:                      resolved       |++++++++++++++++++++++++++++++++++++++| 
        index-sha256:ebdba499e9748fdb7d7a61e3d534af5ad2efa527775d8ce2b30dea866f192f10:    done           |++++++++++++++++++++++++++++++++++++++| 
        manifest-sha256:3cbbf403f9daf623e7db80db3e4d048c292ab61466fe18c715b39752c28835b2: done           |++++++++++++++++++++++++++++++++++++++| 
        config-sha256:1f4036e6cda2bd575617d4204bbaeba9999a07c009fae6692ef307c0389c549f:   done           |++++++++++++++++++++++++++++++++++++++| 
        elapsed: 0.5 s                                                                    total:  14.5 K (28.8 KiB/s)                                      
        bafkreib667i5icm2higgvzgoglesqyw2on4kbgraoa5qk2ubn722zwz4ri:                      resolved       |++++++++++++++++++++++++++++++++++++++| 
        index-sha256:ebdba499e9748fdb7d7a61e3d534af5ad2efa527775d8ce2b30dea866f192f10:    done           |++++++++++++++++++++++++++++++++++++++| 
        manifest-sha256:3cbbf403f9daf623e7db80db3e4d048c292ab61466fe18c715b39752c28835b2: done           |++++++++++++++++++++++++++++++++++++++| 
        config-sha256:1f4036e6cda2bd575617d4204bbaeba9999a07c009fae6692ef307c0389c549f:   done           |++++++++++++++++++++++++++++++++++++++| 
        elapsed: 0.6 s                                                                    total:  14.5 K (24.1 KiB/s)                                      
        time="2023-01-12T13:27:23Z" level=info msg="Creating container nerdctl-compose-test1591673175_wordpress_1"
        time="2023-01-12T13:27:23Z" level=info msg="Creating container nerdctl-compose-test1591673175_db_1"
        time="2023-01-12T13:27:24Z" level=fatal msg="error while creating container nerdctl-compose-test1591673175_db_1: exit status 1"
        
    --- FAIL: TestIPFSComposeUp/stargz (196.47s)

=== FAIL: github.com/containerd/nerdctl/cmd/nerdctl TestIPFSComposeUp/ipfs-address (24.63s)
    compose_up_linux_test.go:79: projectName="nerdctl-compose-test1758711022"
    compose_up_linux_test.go:81: assertion failed: res.ExitCode is not exitCode: time="2023-01-12T13:27:45Z" level=info msg="Creating network nerdctl-compose-test1758711022_default"
        time="2023-01-12T13:27:45Z" level=info msg="Creating volume nerdctl-compose-test1758711022_wordpress"
        time="2023-01-12T13:27:45Z" level=info msg="Creating volume nerdctl-compose-test1758711022_db"
        time="2023-01-12T13:27:45Z" level=info msg="Ensuring image ipfs://bafkreif7vyfj36wyyzxi42pmcor57gamp73mh2cwtjzhio5gukoocu54ku"
        time="2023-01-12T13:27:45Z" level=info msg="Ensuring image ipfs://bafkreiep3tl4cxkt4mlhzjil24cgzi7bqcwckxjm7fy6cx7nnqh56idl44"
        time="2023-01-12T13:27:45Z" level=info msg="Creating container nerdctl-compose-test1758711022_db_1"
        time="2023-01-12T13:27:46Z" level=info msg="Creating container nerdctl-compose-test1758711022_wordpress_1"
        time="2023-01-12T13:27:48Z" level=fatal msg="error while creating container nerdctl-compose-test1758711022_wordpress_1: exit status 1"
        
    --- FAIL: TestIPFSComposeUp/ipfs-address (24.63s)

=== FAIL: github.com/containerd/nerdctl/cmd/nerdctl TestIPFSComposeUp (316.00s)
    ipfs_linux_test.go:80: IPAddress=['"10.4.0.13"' ]
    ipfs_linux_test.go:83: ip address matches=["10.4.0.13" 10.4.0.13]

=== FAIL: github.com/containerd/nerdctl/cmd/nerdctl TestIPFSComposeUp/stargz (re-run 1) (252.96s)
    compose_up_linux_test.go:79: projectName="nerdctl-compose-test3341524720"
    compose_up_linux_test.go:81: assertion failed: res.ExitCode is not exitCode: time="2023-01-12T13:32:02Z" level=info msg="Creating network nerdctl-compose-test3341524720_default"
        time="2023-01-12T13:32:02Z" level=info msg="Creating volume nerdctl-compose-test3341524720_db"
        time="2023-01-12T13:32:02Z" level=info msg="Creating volume nerdctl-compose-test3341524720_wordpress"
        time="2023-01-12T13:32:02Z" level=info msg="Ensuring image ipfs://bafkreib667i5icm2higgvzgoglesqyw2on4kbgraoa5qk2ubn722zwz4ri"
        time="2023-01-12T13:32:02Z" level=info msg="Ensuring image ipfs://bafkreieotogfr4robvzd5qi3ocotvluh3czyflhmgtfte5e5oz2ez3jdoi"
        time="2023-01-12T13:32:02Z" level=info msg="Creating container nerdctl-compose-test3341524720_db_1"
        time="2023-01-12T13:32:02Z" level=info msg="Creating container nerdctl-compose-test3341524720_wordpress_1"
        time="2023-01-12T13:32:03Z" level=fatal msg="error while creating container nerdctl-compose-test3341524720_wordpress_1: exit status 1"
        
    --- FAIL: TestIPFSComposeUp/stargz (252.96s)

=== FAIL: github.com/containerd/nerdctl/cmd/nerdctl TestIPFSComposeUp (re-run 1) (254.23s)
    ipfs_linux_test.go:80: IPAddress=['"10.4.0.47"' ]
    ipfs_linux_test.go:83: ip address matches=["10.4.0.47" 10.4.0.47]

=== FAIL: github.com/containerd/nerdctl/cmd/nerdctl TestIPFSComposeUp/ipfs-address (re-run 1) (19.56s)
    compose_up_linux_test.go:79: projectName="nerdctl-compose-test2983309837"
    compose_up_linux_test.go:81: assertion failed: res.ExitCode is not exitCode: time="2023-01-12T13:32:23Z" level=info msg="Creating network nerdctl-compose-test2983309837_default"
        time="2023-01-12T13:32:23Z" level=info msg="Creating volume nerdctl-compose-test2983309837_wordpress"
        time="2023-01-12T13:32:23Z" level=info msg="Creating volume nerdctl-compose-test2983309837_db"
        time="2023-01-12T13:32:23Z" level=info msg="Ensuring image ipfs://bafkreiep3tl4cxkt4mlhzjil24cgzi7bqcwckxjm7fy6cx7nnqh56idl44"
        time="2023-01-12T13:32:23Z" level=info msg="Ensuring image ipfs://bafkreif7vyfj36wyyzxi42pmcor57gamp73mh2cwtjzhio5gukoocu54ku"
        time="2023-01-12T13:32:23Z" level=info msg="Creating container nerdctl-compose-test2983309837_wordpress_1"
        time="2023-01-12T13:32:23Z" level=fatal msg="error while creating container nerdctl-compose-test2983309837_wordpress_1: exit status 1"
        
    --- FAIL: TestIPFSComposeUp/ipfs-address (19.56s)

=== FAIL: github.com/containerd/nerdctl/cmd/nerdctl TestIPFSComposeUp (re-run 1) (20.17s)
    ipfs_linux_test.go:80: IPAddress=['"10.4.0.48"' ]
    ipfs_linux_test.go:83: ip address matches=["10.4.0.48" 10.4.0.48]

=== FAIL: github.com/containerd/nerdctl/cmd/nerdctl TestIPFSComposeUp/stargz (re-run 2) (196.10s)
    compose_up_linux_test.go:79: projectName="nerdctl-compose-test19763[860](https://github.com/containerd/nerdctl/actions/runs/3902463496/jobs/6665546431#step:5:861)52"
    compose_up_linux_test.go:81: assertion failed: res.ExitCode is not exitCode: time="2023-01-12T13:35:39Z" level=info msg="Creating network nerdctl-compose-test1976386052_default"
        time="2023-01-12T13:35:39Z" level=info msg="Creating volume nerdctl-compose-test1976386052_wordpress"
        time="2023-01-12T13:35:40Z" level=info msg="Creating volume nerdctl-compose-test1976386052_db"
        time="2023-01-12T13:35:40Z" level=info msg="Ensuring image ipfs://bafkreieotogfr4robvzd5qi3ocotvluh3czyflhmgtfte5e5oz2ez3jdoi"
        time="2023-01-12T13:35:40Z" level=info msg="Ensuring image ipfs://bafkreib667i5icm2higgvzgoglesqyw2on4kbgraoa5qk2ubn722zwz4ri"
        time="2023-01-12T13:35:40Z" level=info msg="Creating container nerdctl-compose-test1976386052_wordpress_1"
        time="2023-01-12T13:35:40Z" level=fatal msg="error while creating container nerdctl-compose-test1976386052_wordpress_1: exit status 1"
        
    --- FAIL: TestIPFSComposeUp/stargz (196.10s)

=== FAIL: github.com/containerd/nerdctl/cmd/nerdctl TestIPFSComposeUp (re-run 2) (196.68s)
    ipfs_linux_test.go:80: IPAddress=['"10.4.0.49"' ]
    ipfs_linux_test.go:83: ip address matches=["10.4.0.49" 10.4.0.49]

=== FAIL: github.com/containerd/nerdctl/cmd/nerdctl TestIPFSComposeUp/ipfs-address (re-run 2) (16.14s)
    compose_up_linux_test.go:79: projectName="nerdctl-compose-test3846[915](https://github.com/containerd/nerdctl/actions/runs/3902463496/jobs/6665546431#step:5:916)586"
    compose_up_linux_test.go:81: assertion failed: res.ExitCode is not exitCode: time="2023-01-12T13:35:56Z" level=info msg="Creating network nerdctl-compose-test3846915586_default"
        time="2023-01-12T13:35:56Z" level=info msg="Creating volume nerdctl-compose-test3846915586_wordpress"
        time="2023-01-12T13:35:56Z" level=info msg="Creating volume nerdctl-compose-test3846915586_db"
        time="2023-01-12T13:35:56Z" level=info msg="Ensuring image ipfs://bafkreiep3tl4cxkt4mlhzjil24cgzi7bqcwckxjm7fy6cx7nnqh56idl44"
        time="2023-01-12T13:35:56Z" level=info msg="Ensuring image ipfs://bafkreif7vyfj36wyyzxi42pmcor57gamp73mh2cwtjzhio5gukoocu54ku"
        time="2023-01-12T13:35:56Z" level=info msg="Creating container nerdctl-compose-test3846915586_wordpress_1"
        time="2023-01-12T13:35:57Z" level=fatal msg="error while creating container nerdctl-compose-test3846915586_wordpress_1: exit status 1"
        
    --- FAIL: TestIPFSComposeUp/ipfs-address (16.14s)

=== FAIL: github.com/containerd/nerdctl/cmd/nerdctl TestIPFSComposeUp (re-run 2) (16.73s)
    ipfs_linux_test.go:80: IPAddress=['"10.4.0.50"' ]
    ipfs_linux_test.go:83: ip address matches=["10.4.0.50" 10.4.0.50]

DONE 3 runs, 399 tests, 38 skipped, 11 failures in 1503.405s
Error: Process completed with exit code 1.

https://github.com/containerd/nerdctl/actions/runs/3902463496/jobs/6665546431

AkihiroSuda avatar Jan 13 '23 02:01 AkihiroSuda

parallelize TestIPFSComposeUp for faster test run

The commit title does not reflect the actual content of the commit. Also, could rebase with the latest main branch?

AkihiroSuda avatar Jan 13 '23 07:01 AkihiroSuda

@AkihiroSuda can you please rerun the failed test, they failed for Unable to connect to archive.ubuntu.com

amarlearning avatar Jan 13 '23 09:01 amarlearning

@AkihiroSuda can you please rerun the failed test, they failed for Unable to connect to archive.ubuntu.com

FYI You push can an empty commit to rerun tests. I will re-run them for you

fahedouch avatar Jan 16 '23 14:01 fahedouch

IMO, it is better to send 3 separate PRs for restart policy, logging and ipfs which will make merging faster as the changes have different levels of complexity.

manugupt1 avatar Jan 17 '23 05:01 manugupt1

@amarlearning there has been some work going on wrt CI and specifically IPFS testing that is now making it much more consistent (fail earlier) and running for about ~180s instead.

Do you feel this here is still needed, and that we really can parallelize these, or can we close this?

Thanks!

apostasie avatar Aug 01 '24 18:08 apostasie

It has been a long time since I opened this, let's close this for now. I will open a fresh one.

amarlearning avatar Aug 03 '24 13:08 amarlearning