Connor Peet

Results 463 comments of Connor Peet

That shouldn't affect things because this repo parses JS only, not the TypeScript sources. Are you able to toss your example setup in a repo so I can see your...

This is because we try to still parse the source naively with `acorn` in the transpilation case. With `acorn-loose` it's often good enough but it seems like we get tripped...

Fixed in https://github.com/connor4312/nodejs-testing/commit/08b5a2f4b6e64b9c1fe3dbd60628774cdde57e40, we will now use VS Code's TS language features to do the parsing

An extension profile would be useful: https://github.com/microsoft/vscode/wiki/Performance-Issues#profile-the-running-extensions

Nothing much interesting there. This extension uses the VS Code [`findFiles`](https://github.com/connor4312/nodejs-testing/blob/56749ca5bf37799a26a6fe7ac494d255677bc3e5/src/controller.ts#L322) and then the file watcher APIs to discover tests, it's possible that is running slow. You might also see...

Yea, I can also add some logging there if I see it's taking a while. Since I don't see AST parsing taking any time in your profile (the next step...

I'm curious if you see any difference with version [1.6.2](https://github.com/connor4312/nodejs-testing/releases/tag/v1.6.2) which uses the TS Language Features to do the parsing.

This is kind of a limitation of V8's coverage format. Under the hood we use [v8-to-istanbul](https://github.com/istanbuljs/v8-to-istanbul), but I [plan to](https://github.com/connor4312/nodejs-testing/issues/38#issuecomment-2106682614) do away with that. I'm thinking of doing some AST...

You'll want to update the spec in schema/draft/schema.ts and then `npm r generate:json` to update the JSON schema

@sammorrowdrums also requested this