Connor Peet

Results 463 comments of Connor Peet

This doesn't work on the old debugger either for me. What I tried: 1. Using web-worker demo https://github.com/microsoft/vscode-js-debug/tree/master/demos/web-worker modify the launch config to ```json { "type": "chrome", // or pwa-chrome...

I can repro there. It doesn't look like v1 sets the breakpoints until the scriptParsed event comes in, whereas we set them ahead of time. There are two solutions: 1....

We haven't had any reports of people running into this or 👍's on this issue since js-debug became the default. Do you think this is something we should still look...

The default webRoot is your workspace folder. Please open a new issue if something's going wrong.

Using `callFunctionOn` is the same behavior that Chrome/Edge devtools use to retrieve accessor values. I'm not aware of any other way to evaluate accessors (aside from equivalent evaluations like Runtime.evaluate)....

Good suggestion, we actually had this in early versions of this tool but never got around to reimplementing it... Would not be terribly difficult to PR if you're interested. Debugging...

> This breaks the skipFiles mechanism for files. This is just a cosmetic bug with the label as far as I know > Any Mocha test suite that lists **/node_modules/**...

I would be happy to accept a PR for this, code pointer: https://github.com/microsoft/vscode-js-debug/blob/1ea758e0b8936b3b6cf5ff55414146574dfae7c7/src/common/sourceMaps/sourceMapResolutionUtils.ts#L101-L133

We use [micromatch](https://github.com/micromatch/micromatch) elsewhere in the debugger, you should be able to reuse that 🙂

Right now VS Code does not provide any way for the debugger to do this, we don't know when a node/variable is hovered