monorepo icon indicating copy to clipboard operation
monorepo copied to clipboard

[UI] Showing unsupported route

Open prathmeshkhandelwal1 opened this issue 1 year ago • 9 comments

Describe the bug UI showing dai from BNB to Linea with crazy return amount, which should not be the case Attaching the ss below Screenshot 2024-04-08 at 2.25.06 PM.png

This should be happening due to asset data pulled from getAssetData endpoint, We should only put routes which are in the getSupported route.

Additional context Add any other context about the problem here. @oncall @jwtong

prathmeshkhandelwal1 avatar Apr 08 '24 08:04 prathmeshkhandelwal1

Tasks:

  • Disable LIFI Route
  • Check # of transfers with linea (DAI) route
  • Calculate refund amount

prathmeshkhandelwal1 avatar Apr 11 '24 15:04 prathmeshkhandelwal1

https://www.notion.so/connext/Reliability-a695483dfdd746bfb0700917985ee40f

prathmeshkhandelwal1 avatar Apr 11 '24 15:04 prathmeshkhandelwal1

Query results:

BNB -> Linea:

  • 0x6868a7b67116f3ead4eff99da4cf1901e5e06c064e8264e670c5d8450a35080d
  • 0xcd2af36a2b829e47b2866f6710f0d3743a7aa4fc7fa5e2338bf50a5d28642d75
  • 0x3f6425da52fd5f173f0a04c111f1c9d860f2c22a51f0a472cbf7911329f82b19
  • 0xea72bea7e4bf4f8d2c02fc47fc96ce9398da16bc419d5bde6351b7efafc5eb48
  • 0x19567dff384fc41dc9cfbb8b0652767bb1ce3ddf8b7186b1e6c1ae082f53ff9d
  • 0x4d78c4d4388c89719c166edd8666600dd5115fe0230a8ec0913e597fa09ab12d
0xf08a2567baa5302b79b34ec04802e230c5c2d15b4168518f22bbcf901e1d62ce
0xee8e946303fe10a291e927c2f1edbdd9e784344e46cf5d863d0f19c662f56db5
0xdecffef4ac98f465067713a6ba0dc3655ba29639a54c206ea984e5977b2aafaa
0xd39a9de69eaff50f8fb2687bf6c8d7a6d9640273eb78d72ead8d4b62347ac587
0xa06744163f19ae1e5781db4710280b83f4ff0590c180d01f33b2728c443c4218
0x996fd38fe0e863e030f64b4aac4898f041dbc9a5d0d4d3eb2a628300a2d1aa20
0x969984f75141008536b3962b3ff06a15cd255a9a75cd173c1a978ae896eb0b51
0x7cbc605ebfbeeb9b3daf989fc55c706fd451114ee7a007848cb2e69db7651321
0x76631523f252b5124688bc4cfc783d7db0dded1a906b69ffcf4e53cb6d239d78
0x753693656ef0d48f34de6d33cfcc2332453393a1caa285286ca562685a849026
0x5b02a9a183f78d9e7c1359fb118d50d7b4d50d5223da80c57e40403c1b0e57a3
0x5a5683ce8f885b1e85cc996c91eab95bac267f28df75f5dd7a1d898330351825
0x3b994b8961ed6d13bfb2784dc668c16f1366d2594f2eb74790f20336a913eb90
0x2ddd9a5cd21c71d654c8c5d0110d22390ba38e09bc466a17e93f047a9de3eff2
0x2ad4030cf057cb46e94e3480936a66917b13b072baf1a2455ec9959299ac3754
0x280fd9656f01cb410aab878214fd292ebb1998c809c9723525a4c711cadaf493
0x147f58cd8de30e4eb3edf846d93c78bca257e161ef9c5f15591f01d34d64df24

No Transfers for other routes

@ekbainova You should use this to refund users.

prathmeshkhandelwal1 avatar Apr 11 '24 17:04 prathmeshkhandelwal1

@prathmeshkhandelwal1 Could you help me determine if this problem has a similar nature? Here is the transaction link: https://connextscan.io/tx/0xa54a318bc26665ee08462cc72e3ac432b1056faadd809ef41fd8a77d546f9f2d. Do you think we should issue a refund in this case? You didn't mention it.

ekbainova avatar Apr 11 '24 21:04 ekbainova

lifi is fixing it

yes @ekbainova any DAI transfer to linea

alexwhte avatar Apr 12 '24 18:04 alexwhte

LiFi to use getSupported instead of getAssetsData endpoint. This prevent their UI from displaying routes we've disabled on the server side - need to QA after they update.

just-a-node avatar Apr 15 '24 08:04 just-a-node

Still waiting on LiFi to confirm fix is deployed.

just-a-node avatar Apr 18 '24 15:04 just-a-node

Still waiting on LiFi to confirm fix is deployed.

just-a-node avatar Apr 18 '24 15:04 just-a-node

#6143 - one more case.

ekbainova avatar May 03 '24 06:05 ekbainova

Confirmed on Lifi

just-a-node avatar May 16 '24 23:05 just-a-node