librdkafka icon indicating copy to clipboard operation
librdkafka copied to clipboard

Always define rd_ut_coverage_check

Open StephanDollberg opened this issue 1 year ago • 2 comments
trafficstars

Define rd_ut_coverage_check even in non-devel mode as the lds-gen.py script adds the symbol unconditionally.

Otherwise LLD complains about ld:

error: version script assignment of 'global' to symbol 'rd_ut_coverage_check' failed: symbol not defined

Fixes https://github.com/confluentinc/librdkafka/issues/4593

StephanDollberg avatar Oct 04 '24 12:10 StephanDollberg

:tada: All Contributor License Agreements have been signed. Ready to merge.
:white_check_mark: StephanDollberg
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] avatar Oct 04 '24 12:10 cla-assistant[bot]

Hi Team,

it looks like this change has fallen through the cracks, I wanted to draw attention to it again as the issue is still relevant to us (Envoy project depends on librdkafka for some of our builds and we'd like to update our toolchain to a newer version).

Would it be possible to review the PR, so this fix or some other fix, if you have concerns with this approach, could be merged?

If for some reasons you don't think it makes sense to fix the issue, that would also be a useful signal to have as well. If I can help somehow help to make progress here, I'm happy to assit.

Thank you!

krinkinmu avatar Jan 14 '25 12:01 krinkinmu

Hey @emasab and @pranavrth,

sorry for contacting you directly, but it seems like this PR and the associated bug fell through the cracks and you seem to be the only people who showed any activity in this project recently.

Is there anything I can help with to draw attention to this PR and the associated bug to make progress?

Thank you!

krinkinmu avatar Jan 21 '25 13:01 krinkinmu