librdkafka icon indicating copy to clipboard operation
librdkafka copied to clipboard

Adding int identifier for transactional ID

Open JohnPreston opened this issue 1 year ago • 6 comments
trafficstars

Adding the int ID for transactional ID, to enable using that as a ResourceType in the clients (python being my use-case specifically)

JohnPreston avatar Aug 05 '24 11:08 JohnPreston

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] avatar Aug 05 '24 11:08 cla-assistant[bot]

/sem-approve

pranavrth avatar Aug 08 '24 10:08 pranavrth

/sem-approve Well that was worth a shot :D @pranavrth can you please re-trigger the tests?

JohnPreston avatar Aug 12 '24 13:08 JohnPreston

/sem-approve

pranavrth avatar Aug 21 '24 14:08 pranavrth

I mean, the style check I ran the command to fix that locally so I don't know what else to do here :/ I am not sure why the tests pass on some architecture but not with others. Given that the validation test is to check the value as per a statically expected set of returns, I am not sure how that comes to be.

Any suggestions?

JohnPreston avatar Aug 21 '24 15:08 JohnPreston

The style check works with uncommitted and unstaged changes. Can you try to uncommit your changes and then run make style-fix-changed and then force push the changes to this branch after committing.

Test still fails. Failing on different architecture is not related to the test cases. Its something else that I can check later when the style check and tests passes. Please focus on the Linux Ubuntu x64: source build and Style check jobs in the CI.

Screenshot 2024-08-22 130127

pranavrth avatar Aug 22 '24 07:08 pranavrth

Closing this PR. Continued in https://github.com/confluentinc/librdkafka/pull/4856

pranavrth avatar Sep 30 '24 19:09 pranavrth