librdkafka icon indicating copy to clipboard operation
librdkafka copied to clipboard

Fix for an infinite loop in cooperative sticky assignor

Open emasab opened this issue 1 year ago • 3 comments

when potential topic partitions are less than number of members.

Closes #4783

emasab avatar Jul 31 '24 16:07 emasab

I can confirm this works :) I applied it via a patch in rdkafka-ruby and was not able to trigger it anymore. Thank you!

mensfeld avatar Jul 31 '24 16:07 mensfeld

Thank you @mensfeld ! Couldn't push it earlier because we're reviewing company flows after the incident that happened to public repositories earlier in the month.

emasab avatar Jul 31 '24 17:07 emasab

No worries. You motivated me to finally craft ability to patch librdkafka for rdkafka-ruby so now I can also expose the needed fork-protect APIs for MacOS. Thank you for all your hard work :pray:

mensfeld avatar Jul 31 '24 18:07 mensfeld

:tada: All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@pranavrth I've been running a similar patch for this for weeks, I have specs in rdkafka-ruby and karafka. This solves it as I was able to reproduce it on my side in 100%.

mensfeld avatar Oct 16 '24 08:10 mensfeld

@mensfeld - I was saying that we don't need a test for this kind of trivial bug.

pranavrth avatar Oct 16 '24 08:10 pranavrth