ksql
ksql copied to clipboard
fix: add quotes to connector and source names in java client
Description
The functions describeConnector, createConnector, dropConnector and describeSource did not add quotes to the sql commands sent to the rest endpoints, so case sensitive names weren't preserved.
Testing done
updated unit tests, integration test still passes
Reviewer checklist
- [ ] Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
- [ ] Ensure relevant issues are linked (description should include text like "Fixes #
")
Hey @jzaralim , this functionality is intentional (as least as of today -- we could choose to explicitly change it if this is undesirable, but I think the change is more complicated than what's in this PR, since if we change the case-sensitivity for these methods then we'll want to change it for all methods for consistency). Users can add quotes themselves before passing the strings to the methods, if they want to preserve case-sensitivity. Seems what we really want is (1) a product-level decision on the desired behavior, and (2) a docs update. WDYT? cc @colinhicks as well
@vcrfxia That makes sense, I agree that this should be documented. I'll close this if the consensus is to keep this behaviour.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Zara Lim seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
Closing stale PR. I'm sorry that we didn't get this done. Please resubmit as a new PR if you still want to get it in.