kafka-connect-hdfs icon indicating copy to clipboard operation
kafka-connect-hdfs copied to clipboard

Support N topics written under the same directory #544

Open JozoVilcek opened this issue 4 years ago • 7 comments

Problem

When using a custom partitioner, one can opt out from having topic data separated into topic specific directory. But when writing data from N topics under the same directory, the recovery of offsets is looking for files under paths which does not exists.

Solution

Detect if partitioner us adding topic name to the output path. If not, exclude it from the search path for committed files -> start search from parent directory. This however does not cover generic case when partitioner chooses some exotic path strategy.

Does this solution apply anywhere else?
  • [ ] yes
  • [x] no
If yes, where?

Test Strategy

Testing done:
  • [x] Unit tests
  • [x] Integration tests
  • [ ] System tests
  • [x] Manual tests

Release Plan

JozoVilcek avatar Mar 17 '21 12:03 JozoVilcek

It looks like @JozoVilcek hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence. Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

ghost avatar Mar 17 '21 12:03 ghost

[clabot:check]

JozoVilcek avatar Mar 17 '21 12:03 JozoVilcek

@confluentinc It looks like @JozoVilcek just signed our Contributor License Agreement. :+1:

Always at your service,

clabot

ghost avatar Mar 17 '21 12:03 ghost

Does this PR make sense? Any kind of feedback is much appreciated

JozoVilcek avatar Aug 17 '21 08:08 JozoVilcek

@kpatelatwork I did find you active in other MRs. Can you help me how can I bring contributions into the attention of code owners? I have problem to get feedback on this and few other old MRs

JozoVilcek avatar May 23 '22 17:05 JozoVilcek

@janjwerner-confluent , @rishabhbits038 could you please review this request and let me know the feedback if this has a chance to get in. If yes I would work on updating the PR and make it green

JozoVilcek avatar Jun 13 '23 08:06 JozoVilcek

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

cla-assistant[bot] avatar Aug 27 '23 12:08 cla-assistant[bot]