kafka-connect-hdfs icon indicating copy to clipboard operation
kafka-connect-hdfs copied to clipboard

Add compression config for Parquest files

Open orinciog opened this issue 5 years ago • 9 comments

I've added a config for this plugin in order to specify the compression for parquest files.

The setting is called 'parquet.codec' and can have the following values: none, snappy, gzip, brotli, lz4, lzo, zstd.

orinciog avatar Apr 06 '20 10:04 orinciog

It looks like @orinciog hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence. Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

ghost avatar Apr 06 '20 10:04 ghost

[clabot:check]

orinciog avatar Apr 06 '20 11:04 orinciog

@confluentinc It looks like @orinciog just signed our Contributor License Agreement. :+1:

Always at your service,

clabot

ghost avatar Apr 06 '20 11:04 ghost

@orinciog Could you please add details on the testing done? Also if you could add the test coverage, it would be great and easy for us to review this. Thank you!

sonupillai avatar Dec 07 '20 00:12 sonupillai

@orinciog Overall, this change looks good. Can you add some tests/describe your testing methodology here?

ilanjiR avatar Jan 06 '21 00:01 ilanjiR

@ilanjiR Thank you for your message. We already use a patched version of kafka connect hdfs which includes these changes in it.

We are using parquet.codec=gzip setting in our kafka-connect configuration.

All parquet files in hdfs are compressed gzip.

Thank you,

orinciog avatar Jan 11 '21 14:01 orinciog

@levzem levzemWhy is this PR not merged, but parquet.codec is listed in the document description https://docs.confluent.io/kafka-connect-hdfs/current/configuration_options.html#connector last configuration description

RuiFG avatar May 27 '21 13:05 RuiFG

@levzem What extra details should I provide in order to merge this PR? Thank you.

orinciog avatar Jul 08 '21 15:07 orinciog

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

:x: oranciog-bd
:x: orinciog
You have signed the CLA already but the status is still pending? Let us recheck it.

cla-assistant[bot] avatar Aug 27 '23 12:08 cla-assistant[bot]