kafka-connect-hdfs icon indicating copy to clipboard operation
kafka-connect-hdfs copied to clipboard

Use new API from confluentinc/kafka-connect-storage-common#77

Open dcsobral opened this issue 7 years ago • 2 comments

The API change itself is trivial to adopt. Get the original values, add the defaults, and that's done.

However, many tests either relied on implementation details of the partitioners, or ignored the mechanism used in the very same tests to pass settings in a reliable way and, instead, modified the configuration right before it was passed to the partitioner, which made it unavailable elsewhere as code migrated to relying on HdfsSinkConnectorConfig instead of the no-longer present parsed config map.

dcsobral avatar Jul 12 '18 08:07 dcsobral

@confluentinc It looks like @dcsobral just signed our Contributor License Agreement. :+1:

Always at your service,

clabot

ghost avatar Jul 12 '18 08:07 ghost

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

cla-assistant[bot] avatar Aug 27 '23 12:08 cla-assistant[bot]