kafka-connect-elasticsearch icon indicating copy to clipboard operation
kafka-connect-elasticsearch copied to clipboard

Add Version Type & Field Configuration

Open jokefaker opened this issue 3 years ago • 2 comments

Problem

  • Not able to custom version type
  • Not able to set custom version when use external version type

Solution

  • add version.type configuration: internal, external, external_gte
  • add version.field configuration to support read version value from payload
  • use version.type and version.field in data convert
Does this solution apply anywhere else?
  • [ ] yes
  • [x] no
If yes, where?

Test Strategy

Testing if version.type and version.type.field is set, and check if IndexRequest is correct

Testing done:
  • [x] Unit tests
  • [ ] Integration tests
  • [ ] System tests
  • [ ] Manual tests

Release Plan

This feature is backwards compatible. Merging to master Rolling back might result in validation error for people that use version.type or version.type.field

jokefaker avatar Jun 22 '22 06:06 jokefaker

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jun 22 '22 06:06 CLAassistant

is there a possibility of this being merged?

blackmad avatar Jan 10 '23 19:01 blackmad