kafka-connect-elasticsearch icon indicating copy to clipboard operation
kafka-connect-elasticsearch copied to clipboard

Add RequestAcceptEncoding interceptor for compression

Open sincejune opened this issue 4 years ago • 4 comments

Problem

Currently, the compression flag(connection.compression) is not working due to the missing of RequestAcceptEncoding interceptor in HTTP client.

Solution

This PR added RequestAcceptEncoding interceptor in HTTP client builder to apply Accept-Encoding: gzip,deflate header.

Does this solution apply anywhere else?
  • [x] yes
  • [ ] no
If yes, where?

This interceptor should affect all requests to ElasticSearch which used the ConfigCallbackHandler handler.

Test Strategy

Testing done:
  • [ ] Unit tests
  • [ ] Integration tests
  • [ ] System tests
  • [x] Manual tests

Release Plan

sincejune avatar Jul 06 '21 14:07 sincejune

It looks like @sincejune hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence. Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

ghost avatar Jul 06 '21 14:07 ghost

[clabot:check]

sincejune avatar Jul 06 '21 14:07 sincejune

@confluentinc It looks like @sincejune just signed our Contributor License Agreement. :+1:

Always at your service,

clabot

ghost avatar Jul 06 '21 14:07 ghost

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

cla-assistant[bot] avatar Sep 11 '23 09:09 cla-assistant[bot]