Update docker-compose.yml

[mcascallares]

trafficstars

Automatic observer promotion requires version:2 for log.placement.constraints

Description

What behavior does this PR change, and why?

Author Validation

Describe the validation already done, or needs to be done, by the PR submitter.

Reviewer Tasks

Describe the tasks/validation that the PR submitter is requesting to be done by the reviewer.

[ybyzek]

@mcascallares thanks for the PR. Can you please update the description with details and reference links if available? For example, the tutorial appears to work today without this PR -- is that actually not true?

[mcascallares]

Hi @ybyzek

We just tested it today with version 1, simulating the failover scenario and it didn't work.

@csarrazi discovered this blog post https://www.confluent.io/blog/automatic-observer-promotion-for-safe-multi-datacenter-failover-in-confluent-6-1/ that explicitly states "Automatic Observer Promotion is activated by changing the version of the replica placement policy to two."

Hope this helps!

[ybyzek]

We just tested it today with version 1, simulating the failover scenario and it didn't work.

Can you please elaborate on "it didn't work"? What was the symptom? This will help me validate the PR

[mcascallares]

Sorry, my bad.

"It didn't work" -> when we brought down one of the ISR, and the observerPromotionPolicy was met, it didn't promote one of the observers. @csarrazi discovered that blog post, we switched from v1 to v2 as my PR, and the automatic promotion was triggered.

It is also highlighted in our docs https://docs.confluent.io/platform/current/multi-dc-deployments/multi-region.html#automatic-observer-promotion

[ybyzek]

There are specific topics that showcase the automatic observer promotion behavior, and they all use version=2 (see directory https://github.com/confluentinc/examples/tree/6.1.1-post/multiregion/config):

https://github.com/confluentinc/examples/blob/6.1.1-post/multiregion/config/placement-multi-region-async-op-leader-is-observer.json#L2 https://github.com/confluentinc/examples/blob/6.1.1-post/multiregion/config/placement-multi-region-async-op-under-min-isr.json#L2 https://github.com/confluentinc/examples/blob/6.1.1-post/multiregion/config/placement-multi-region-async-op-under-replicated.json#L2

So the PR as it stands today -- I'm still not clear what affect it has in the tutorial.

cc: @thomaskwscott who added Automatic Observer Promotion into this tutorial, for additional comment