cp-all-in-one icon indicating copy to clipboard operation
cp-all-in-one copied to clipboard

Published 20 hours ago • verified publisher icon confluentinc

Update docker-compose.yml

Open zigorasjsjsk opened this issue 7 months ago • 3 comments

Description

What behavior does this PR change, and why?

Author Validation

Describe the validation already done, or needs to be done, by the PR submitter.

Reviewer Tasks

Describe the tasks/validation that the PR submitter is requesting to be done by the reviewer.

zigorasjsjsk avatar Apr 06 '25 15:04 zigorasjsjsk

Please sign the Contributor License Agreement here before this PR can be approved.
:x: zigorasjsjsk
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

confluent-cla-assistant[bot] avatar Apr 06 '25 15:04 confluent-cla-assistant[bot]

Hhhyhh

zigorasjsjsk avatar Apr 06 '25 16:04 zigorasjsjsk

@zigorasjsjsk is this strictly a stylistic change or is it broken for you with the doc separator directive? for me it works either way. it seems like a worthwhile change since most docker compose examples I can find, plus docker compose docs, generally don't have the leading ---. I think that it should be made across all of the compose files in this repo though. Let me know if you'd make that change or if not I can open a separate PR to do that

davetroiano avatar Apr 07 '25 16:04 davetroiano

done in this PR: https://github.com/confluentinc/cp-all-in-one/pull/219

davetroiano avatar Jun 24 '25 15:06 davetroiano