confluent-kafka-python
confluent-kafka-python copied to clipboard
please remove installation of LICENSE as datafile
Description
Currently the setuptools integration is installing the LICENSE.txt as a datafile. datafiles are meant to be used for installation of files needed at runtime of the library. the license is usually installed as part of packaging processes alongside other documentation.
Installation as datafile brings this into the wrong FHS path layer and hence should be skipped.
i submitted this as https://github.com/confluentinc/confluent-kafka-python/pull/713, but I can not sign the CLA. Please take it as a public domain contribution, I refuse to claim any copyright on it.
How to reproduce
Checklist
Please provide the following information:
- [ ] confluent-kafka-python and librdkafka version (
confluent_kafka.version()andconfluent_kafka.libversion()): - [ ] Apache Kafka broker version:
- [ ] Client configuration:
{...} - [ ] Operating system:
- [ ] Provide client logs (with
'debug': '..'as necessary) - [ ] Provide broker log excerpts
- [ ] Critical issue
https://github.com/confluentinc/confluent-kafka-python/blob/master/setup.py#L73
#1336 has a fix for this -- just needs to be merged
https://github.com/confluentinc/confluent-kafka-python/pull/713 has it as well, and CLA is approved.
fwiw I've signed several CLAs for this over the year and half it's been open -- so one of those should be honored even though confluent switch tools along the way