confluent-kafka-python icon indicating copy to clipboard operation
confluent-kafka-python copied to clipboard

please remove installation of LICENSE as datafile

Open dirkmueller opened this issue 6 years ago • 4 comments

Description

Currently the setuptools integration is installing the LICENSE.txt as a datafile. datafiles are meant to be used for installation of files needed at runtime of the library. the license is usually installed as part of packaging processes alongside other documentation.

Installation as datafile brings this into the wrong FHS path layer and hence should be skipped.

i submitted this as https://github.com/confluentinc/confluent-kafka-python/pull/713, but I can not sign the CLA. Please take it as a public domain contribution, I refuse to claim any copyright on it.

How to reproduce

Checklist

Please provide the following information:

  • [ ] confluent-kafka-python and librdkafka version (confluent_kafka.version() and confluent_kafka.libversion()):
  • [ ] Apache Kafka broker version:
  • [ ] Client configuration: {...}
  • [ ] Operating system:
  • [ ] Provide client logs (with 'debug': '..' as necessary)
  • [ ] Provide broker log excerpts
  • [ ] Critical issue

dirkmueller avatar Oct 31 '19 09:10 dirkmueller

https://github.com/confluentinc/confluent-kafka-python/blob/master/setup.py#L73

isaulv avatar May 09 '20 20:05 isaulv

#1336 has a fix for this -- just needs to be merged

asottile-sentry avatar May 22 '23 17:05 asottile-sentry

https://github.com/confluentinc/confluent-kafka-python/pull/713 has it as well, and CLA is approved.

dirkmueller avatar Oct 18 '23 21:10 dirkmueller

fwiw I've signed several CLAs for this over the year and half it's been open -- so one of those should be honored even though confluent switch tools along the way

asottile-sentry avatar Oct 18 '23 21:10 asottile-sentry