confluent-kafka-python
confluent-kafka-python copied to clipboard
confluentinc
Document that offsets_for_times accepts milliseconds
Other confluent-kafka-python APIs accept seconds since epoch, but this one uses milliseconds, so it's easy to think it accepts seconds. That would generally result in replaying all events.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
~~I'd have to go to Legal to check if I can sign that CLA, which doesn't seem worth it for a one-line doc change. If someone who has already signed wants to make a similar change instead, go for it.~~
@pranavrth (Picking you at random) -- can I get someone to take a look at this small change? I suspect this PR was simply missed due to the CLA issues, which I've since resolved.
Tried to get a review from contact at Confluent as well, but no luck. I have to assume this repo doesn't actually take contributions -- closing out PR.