confluent-kafka-python icon indicating copy to clipboard operation
confluent-kafka-python copied to clipboard

CLIENTS-2607 - Updated docs to emphasize using logger instead of log_…

Open pranavrth opened this issue 3 years ago • 2 comments

These changes are related to the users getting confused for logger callback property. In the docs we refer to librdkafka properties first then explain logger properties of python client. Due to this, users tries to use log_cb property for log callback and fail.

In this PR, I tried to change our docs to reflect to use logger instead of log_cb configuration property.

Changes in the PR:

  1. Updated configuration property doc to make sure that we specify python client specific properties before librdkafka properties.
  2. added test cases to make sure the custom logger is logging in the correct format

pranavrth avatar Sep 13 '22 05:09 pranavrth

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 13 '22 05:09 CLAassistant

Docs would look like this:-

Screenshot 2022-09-13 at 2 10 18 PM Screenshot 2022-09-13 at 2 07 18 PM

pranavrth avatar Sep 13 '22 08:09 pranavrth

Merged the changes in another PR - https://github.com/confluentinc/confluent-kafka-python/pull/1447.

Closing this one.

pranavrth avatar Nov 02 '22 11:11 pranavrth