confluent-kafka-javascript icon indicating copy to clipboard operation
confluent-kafka-javascript copied to clipboard

feat: add support for Node v24

Open weyert opened this issue 6 months ago • 1 comments

What

Updated semaphore.yml to add support for Node.js v24.

Used the ABI version as listed in the JSON file located at: https://github.com/nodejs/node/blob/main/doc/abi_version_registry.json

fixes #306

Checklist

  • [ ] Contains customer facing changes? Including API/behavior changes
  • [ ] Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required

References

JIRA:

Test & Review

No testing done. Unclear how to run semaphore.yml file

Open questions / Follow-ups

weyert avatar May 09 '25 20:05 weyert

Any plans to merge this?

weyert avatar May 16 '25 19:05 weyert

@weyert , yep, do you mind if I take your commit into an internal branch and merge it that way? I can't tag a commit on an external branch (to check building of binaries for all supported platforms).

milindl avatar May 21 '25 04:05 milindl

@weyert , yep, do you mind if I take your commit into an internal branch and merge it that way? I can't tag a commit on an external branch (to check building of binaries for all supported platforms).

Sure, no problem :)

weyert avatar Jun 14 '25 00:06 weyert

Closing with merge into master and now that 1.4.0 is released, thanks @weyert

milindl avatar Jul 03 '25 17:07 milindl