confluent-kafka-go icon indicating copy to clipboard operation
confluent-kafka-go copied to clipboard

bugfix: update protobuf.Deserializer to use base class implementation of ConfigureDeserializer

Open ideasculptor opened this issue 2 years ago • 1 comments

Copying the functionality of a base implementation into the extending struct's implementation is a recipe for later bugs when changes are made in the base implementation that don't get copied into the extending implementation. It is far better to call the base implementation and then just perform actions that are extension-specific in the extending implementation.

ideasculptor avatar Mar 29 '23 18:03 ideasculptor

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: rayokota
:x: Samuel Gendler


Samuel Gendler seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

cla-assistant[bot] avatar Aug 04 '23 11:08 cla-assistant[bot]