cli icon indicating copy to clipboard operation
cli copied to clipboard

[WIP - DO NOT MERGE][SCP-4543] : CLI changes to support custom connector plugins on GCP

Open kishantr opened this issue 7 months ago • 3 comments

Release Notes

New Features

  • Add support for gcp cloud in confluent connect custom-plugin commands

Checklist

  • [x] I have successfully built and used a custom CLI binary, without linter issues from this PR.
  • [x] I have clearly specified in the What section below whether this PR applies to Confluent Cloud, Confluent Platform, or both.
  • [x] I have verified this PR in Confluent Cloud pre-prod or production environment, if applicable.
  • [ ] I have verified this PR in Confluent Platform on-premises environment, if applicable.
  • [x] I have attached manual CLI verification results or screenshots in the Test & Review section below.
  • [x] I have added appropriate CLI integration or unit tests for any new or updated commands and functionality.
  • [x] I confirm that this PR introduces no breaking changes or backward compatibility issues.
  • [x] I have indicated the potential customer impact if something goes wrong in the Blast Radius section below.
  • [x] I have put checkmarks below confirming that the feature associated with this PR is enabled in:
    • [ ] Confluent Cloud prod
    • [x] Confluent Cloud stag
    • [x] Confluent Cloud devel
    • [ ] Confluent Platform
    • [ ] Check this box if the feature is enabled for certain organizations only

What

  • The PR contains changes to support GCP for custom connect plugin management operations in Confluent Cloud
    • Introduce a new internal method UploadFileToGoogleCloudStorage to support file uploads to google cloud storage.
    • Refactor existing method for azure and extract common code into a separate method.
    • Add test for describing gcp plugins

Blast Radius

  • Confluent Cloud customers using confluent connect custom-plugin create commands to create azure/ gcp plugins will be blocked

References

  • https://confluentinc.atlassian.net/browse/CLI-3442
  • https://confluentinc.atlassian.net/wiki/x/t4Yu-Q
  • https://confluentinc.atlassian.net/wiki/x/5ANW9Q

Previous similar PR for azure

  • https://github.com/confluentinc/cli/pull/2683

Test & Review

The PR has been tested through a local binary in devel and below are the attached screenshots


  • GCP
Screenshot 2025-03-31 at 9 04 51 PM Screenshot 2025-03-31 at 9 06 12 PM Screenshot 2025-03-31 at 9 06 43 PM Screenshot 2025-03-31 at 9 07 26 PM Screenshot 2025-03-31 at 9 08 23 PM
  • AZURE
Screenshot 2025-03-31 at 9 23 54 PM

Google sheet for more tests - link

kishantr avatar Apr 01 '25 04:04 kishantr

:tada: All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Overall it looks great, thanks for sharing the verification results.

Please rebase with the latest of CLI main repo which should fix the CI/CD pipeline failures.

Also, since the custom plugin version command is not launched yet, can you please attach test in prod environment to make sure this command doesn't show up?

Additionally, is there a timeline to make the custom plugin version command publicly available?

channingdong avatar Apr 04 '25 00:04 channingdong

Thanks for the review! sure

Also, since the custom plugin version command is not launched yet, can you please attach test in prod environment to make sure this command doesn't show up?

Thanks for raising this. Yes, it is controlled via a feature flag - ref and shouldn't be enabled in prod cc: @NicoleYWDu

Prod test:

Screenshot 2025-04-03 at 5 57 18 PM

Additionally, is there a timeline to make the custom plugin version command publicly available?

I am not exactly sure about the timelines. The plugin versioning feature is now being handled by the managed connect team ( instead of the custom connect team ) and I think they still need to make the cli changes for plugin version operations. I will add @arihant-confluent as a reviewer and ask for more details

kishantr avatar Apr 04 '25 01:04 kishantr

image @kishantr I see you edited the method `UploadFileToAzureBlob`, which is used by the custom connector version create command and the artifact create command. Can you please further verify that those still work as expected to ensure we don't break those? We should also include this in the blast radius.

danielayaz avatar Jun 10 '25 15:06 danielayaz

@danielayaz thanks for the review! I have attached the flink artifact create and custom-plugin version create command result screenshots in the PR. I have also updated the blast radius section. One thing to add is that the custom-plugin version commands are not GA'ed for prod yet and will be replaced as part of this

kishantr avatar Jun 10 '25 18:06 kishantr