kafka-security-manager icon indicating copy to clipboard operation
kafka-security-manager copied to clipboard

Slack Notification Exception Handling

Open captoaks opened this issue 6 years ago • 1 comments

If KSM fails to connect to Slack the KSM app itself terminates seemingly due to a lack of exception handling around sending Slack notifications. Please can some exception handling be added?

[2019-08-27 08:44:14,600] ERROR unexpected exception (com.github.simplesteph.ksm.KafkaSecurityManager$) java.util.concurrent.ExecutionException: java.net.SocketTimeoutException: connect timed out

captoaks avatar Aug 28 '19 10:08 captoaks

I'm opened to PR for this, it should be an easy one

On Wed., 28 Aug. 2019, 12:53 pm captoaks, [email protected] wrote:

If KSM fails to connect to Slack the KSM app itself terminates seemingly due to a lack of exception handling around sending Slack notifications. Please can some exception handling be added?

[2019-08-27 08:44:14,600] ERROR unexpected exception (com.github.simplesteph.ksm.KafkaSecurityManager$) java.util.concurrent.ExecutionException: java.net.SocketTimeoutException: connect timed out

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/simplesteph/kafka-security-manager/issues/54?email_source=notifications&email_token=AE7CW2IR66SVZ6VCOXEMTY3QGZKK5A5CNFSM4IRCVFK2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HH4NQOQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AE7CW2KJCXBYITLGFXBCUE3QGZKK5ANCNFSM4IRCVFKQ .

simplesteph avatar Aug 28 '19 11:08 simplesteph