examples2 icon indicating copy to clipboard operation
examples2 copied to clipboard

CI examples

Open memsharded opened this issue 3 years ago • 7 comments
trafficstars

memsharded avatar Mar 10 '22 14:03 memsharded

I think the set of operations done in this example is enough to start to understand the basic tools you have in Conan to setup your ci flows. Just some comments if you consider they could be useful:

  • Could we rename matrix to math and physx that is an actual sdk to physics? Also I had sometimes difficulties figuring the connections between the different libraries... for me it was not so natural that gameserver dependend on physx, maybe if it was on network or something like that...
  • Could we add for each step a more detailed explanation and also what the person that executes those steps should have learned while doing it? Also an ASCII graph of the dependencies and applications would be nice.
  • Before we merge I think we should put the example in a more meaningful location or at least less generic than examples/ci/game

czoido avatar Mar 10 '22 17:03 czoido

Could we rename matrix to math and physx that is an actual sdk to physics? Also I had sometimes difficulties figuring the connections between the different libraries... for me it was not so natural that gameserver dependend on physx, maybe if it was on network or something like that...

I started using math and it was very problematic because it was colliding with the system math.h. Then I could start renaming the files and libraries inside the math package for something different, but it didn't look great. I am fine with renaming "physics", or using any other package name. The thing is that "network" depending on "matrix" didn't have much sense either, and I wanted to have that diamond. So suggestion welcome

Could we add for each step a more detailed explanation and also what the person that executes those steps should have learned while doing it? Also an ASCII graph of the dependencies and applications would be nice.

Yes, the documentation, slides, graph, etc will follow. I wanted to make sure the proposed CI flow makes sense first. I don't think the docs in the run_example.py should be more exhaustive, but in the main Conan docs.

Before we merge I think we should put the example in a more meaningful location or at least less generic than examples/ci/game

Agree, to discuss where.

memsharded avatar Mar 10 '22 17:03 memsharded

Could we rename matrix to math and physx that is an actual sdk to physics? Also I had sometimes difficulties figuring the connections between the different libraries... for me it was not so natural that gameserver dependend on physx, maybe if it was on network or something like that...

I started using math and it was very problematic because it was colliding with the system math.h. Then I could start renaming the files and libraries inside the math package for something different, but it didn't look great. I am fine with renaming "physics", or using any other package name. The thing is that "network" depending on "matrix" didn't have much sense either, and I wanted to have that diamond. So suggestion welcome

Oh, I see... Let's keep it as is for the moment and take a moment to do some brainstorming before merging and see if we come up with something very intuitive.

Could we add for each step a more detailed explanation and also what the person that executes those steps should have learned while doing it? Also an ASCII graph of the dependencies and applications would be nice.

Yes, the documentation, slides, graph, etc will follow. I wanted to make sure the proposed CI flow makes sense first. I don't think the docs in the run_example.py should be more exhaustive, but in the main Conan docs.

Yes, I meant to make it easier to review this kind of PR, just some basics of what you are trying to teach for each step would be very helpful when reviewing at least.

czoido avatar Mar 10 '22 17:03 czoido

What about a dumb/simplegame that does not depend on the AI, just have some graphics? Like this:

image

Maybe it's a bit more intuitive?

czoido avatar Mar 11 '22 07:03 czoido

Great job @memsharded About the discussion of the names, what about this diagram? Perhaps, it's a bit more intuitive:

image

franramirez688 avatar Mar 11 '22 08:03 franramirez688

Great job @memsharded About the discussion of the names, what about this diagram? Perhaps, it's a bit more intuitive:

image

I like the simpleplot idea, but I would keep mathlib that is a typical one for this kind of applications

czoido avatar Mar 11 '22 08:03 czoido

I like the simpleplot idea, but I would keep mathlib that is a typical one for this kind of applications

As discussed before:

image

franramirez688 avatar Mar 11 '22 10:03 franramirez688