examples2 icon indicating copy to clipboard operation
examples2 copied to clipboard

Add MakeDeps example

Open uilianries opened this issue 2 years ago • 5 comments
trafficstars

Some of Poco deps requires GCC >=7

  • [x] Tested locally on Linux
  • [x] Tested locally on OSX
  • [ ] ~Tested locally on Windows~

No support for Windows now, let's postpone it as will require msys2

uilianries avatar Aug 29 '23 09:08 uilianries

It fails because MakeDeps is not available yet in current version.

uilianries avatar Aug 29 '23 11:08 uilianries

We can not use Poco, because we will need C++17:

libmysqlclient/8.0.31: Cannot build for this configuration: Current cppstd (gnu14) is lower than the required C++ standard (17).

uilianries avatar Aug 30 '23 08:08 uilianries

Great! Just a two things:

  • Don't forget to update the README for the corresponding section of the examples2 repo
  • All examples should have a corresponding documentation. Is there a corresponding PR for the docs too?

czoido avatar Sep 07 '23 10:09 czoido

  • [x] Update the README for the corresponding section of the examples2 repo
  • [x] All examples should have a corresponding documentation.

uilianries avatar Sep 07 '23 10:09 uilianries

@czoido Yes, now is everything correct:

  • README has a new entry pointing to MakeDeps example
  • There is a new PR in docs related to this example: https://github.com/conan-io/docs/pull/3364

uilianries avatar Sep 07 '23 12:09 uilianries