docs icon indicating copy to clipboard operation
docs copied to clipboard
verified publisher icon conan-io

msvc package

Open memsharded opened this issue 1 year ago • 2 comments

Close https://github.com/conan-io/conan-recipes-contrib/issues/1

memsharded avatar Apr 05 '24 09:04 memsharded

Just a few notes from me:

  • I wouldn't advise renaming C:/Program Files (x86)/Microsoft Visual Studio/2019 to C:/Program Files (x86)/Microsoft Visual Studio/2019_2. This breaks a valid installation, and it's a system location. I would advise packaging the installation with the Windows Sandbox and retrieving the Conan package outside of it (conan upload, conan cache save, etc), or alternatively use the command line interface to the visual studio installer and specify an --installPath

  • A working installation of Visual C++ would need access to the Windows SDK (for windows headers and so on) - if I'm not mistaken, those paths would not be copied into the package in the given example, so it is not self-contained

  • CMake seems to use vswhere.exe and query the Windows registry to locate some things (at least the Windows SDK which is not being packaged here) - those may not work.

I'd say this needs more testing - it looks like it only works on a machine that already has visual studio installed

jcar87 avatar May 20 '24 14:05 jcar87

https://gist.github.com/mmozeiko/7f3162ec2988e81e56d5c4e22cde9977 is a good information, thanks @jcar87

memsharded avatar May 21 '24 15:05 memsharded