conan-clion-plugin icon indicating copy to clipboard operation
conan-clion-plugin copied to clipboard

Plugin seems to add a ton of duplicate arguments

Open etodanik opened this issue 2 years ago • 5 comments

I end up getting stuff like:

-DBUILD_TESTING:BOOL=ON -DBUILD_SHARED_LIBS:BOOL=OFF -DCMAKE_PROJECT_TOP_LEVEL_INCLUDES=C:\Users\danny\CLionProjects\elixir-overlay\conan_provider.cmake -DCONAN_COMMAND="C:\Program Files\Conan\conan\conan.exe" -DBUILD_INTEGRATION:BOOL=ON -DBUILD_WITH_MT:BOOL=ON -DCEF_RUNTIME_LIBRARY_FLAG:STRING=/MT -DUSE_SANDBOX:BOOL=OFF -DCMAKE_PROJECT_TOP_LEVEL_INCLUDES="C:\Users\danny\CLionProjects\elixir-overlay\conan_provider.cmake"

With multiple conan_provider.cmake references.

etodanik avatar Aug 31 '23 01:08 etodanik

Hi @israelidanny,

Thanks a lot for reporting. I could not reproduce it so far. Could you please comment the steps you followed until that happens?

czoido avatar Aug 31 '23 08:08 czoido

Hard to say. I can say for sure though that no matter how much I try to remove extra strings, the plug-in keeps adding and adding.

etodanik avatar Aug 31 '23 08:08 etodanik

But do you know which action makes that the repeated CMAKE_PROJECT_TOP_LEVEL_INCLUDES is added? Maybe that way I could reproduce. Does it happen for a new empty project from scratch as well?

czoido avatar Aug 31 '23 13:08 czoido

I'll try to poke at it a bit more after my deadline on the 7th of September. But mostly right now it keeps happening persistently even after deletion, seemingly whenever cmake runs and conan install does too? I'm not 100% sure.

On Thu, 31 Aug 2023 at 16:39, Carlos Zoido @.***> wrote:

But do you know which action makes that the repeated CMAKE_PROJECT_TOP_LEVEL_INCLUDES is added? Maybe that way I could reproduce. Does it happen for a new empty project from scratch as well?

— Reply to this email directly, view it on GitHub https://github.com/conan-io/conan-clion-plugin/issues/148#issuecomment-1701059284, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPBB6E2L7KVBSOD2I4B6XDXYCHYNANCNFSM6AAAAAA4FKWROE . You are receiving this because you were mentioned.Message ID: @.***>

etodanik avatar Aug 31 '23 14:08 etodanik

Also, one more observation- it seems to alternate between those two forms:

-DCMAKE_PROJECT_TOP_LEVEL_INCLUDES=C:\Users\danny\CLionProjects\elixir-overlay\conan_provider.cmake
-DCMAKE_PROJECT_TOP_LEVEL_INCLUDES="C:\Users\danny\CLionProjects\elixir-overlay\conan_provider.cmake"

With or without double quotes.

etodanik avatar Sep 03 '23 13:09 etodanik