conan-center-index icon indicating copy to clipboard operation
conan-center-index copied to clipboard

qtkeychain: initial

Open DeepDiver1975 opened this issue 8 months ago • 11 comments

Summary

Changes to recipe: lib/qtkeychain

Motivation

fixes #19046

Details

Introduce new recipe qtkeychain


DeepDiver1975 avatar Mar 13 '25 22:03 DeepDiver1975

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 13 '25 22:03 CLAassistant

Update pushed to resolve linter warnings.

DeepDiver1975 avatar Mar 14 '25 12:03 DeepDiver1975

  • Tested locally with at least one configuration using a recent version of Conan

Local build is currently blocked by https://github.com/frankosterfeld/qtkeychain/issues/267 ... :shrug:

DeepDiver1975 avatar Mar 15 '25 22:03 DeepDiver1975

I did some cleanups, some work still needs to be done, thanks

Will be watching and learning ... ;-)

DeepDiver1975 avatar Mar 15 '25 23:03 DeepDiver1975

FYI: the build is now working properly on Linux :dancers:

DeepDiver1975 avatar Mar 16 '25 18:03 DeepDiver1975

@AbrilRBS are we missing the qt option 'with_doubleconversion'?

https://github.com/conan-io/conan-center-index/blob/62d2d8fa803b2c395e32ed78d1d4e2f9f02be53c/recipes/qt/6.x.x/conanfile.py#L353-L354

DeepDiver1975 avatar Mar 20 '25 14:03 DeepDiver1975

@AbrilRBS are we missing the qt option 'with_doubleconversion'?

https://github.com/conan-io/conan-center-index/blob/62d2d8fa803b2c395e32ed78d1d4e2f9f02be53c/recipes/qt/6.x.x/conanfile.py#L353-L354

Sorry for the delay. The multiconfiguration option is off by default so double-conversion won't be built by default, but I can't seem to find where double-conversion is required to be used in qtkeychain, can you point me to the codepath that uses it? Thanks!

AbrilRBS avatar Mar 24 '25 09:03 AbrilRBS

but I can't seem to find where double-conversion is required to be used in qtkeychain, can you point me to the codepath that uses it?

I could not find it either ... by proposal to fix was more derived from the compiler error than from qtkeychain inner needs ...

DeepDiver1975 avatar Mar 24 '25 10:03 DeepDiver1975

by proposal to fix was more derived from the compiler error than from qtkeychain inner needs

I think we should find why this fails the way it does. If the proper solution is to have qt built with those extra options, then we'll merge with the check in the validate method checking for their values, but it would be preferrable if we understand if/how we need it, in order to be able to publish binaries for this :)

AbrilRBS avatar Mar 31 '25 19:03 AbrilRBS

I think we should find why this fails the way it does. If the proper solution is to have qt built with those extra options, then we'll merge with the check in the validate method checking for their values, but it would be preferrable if we understand if/how we need it, in order to be able to publish binaries for this :)

@AbrilRBS can we drag somebody in here with deeper understanding of the qt build? I am just a consumer of the libraries and currently lack deeper understanding. THX you!

DeepDiver1975 avatar Apr 24 '25 10:04 DeepDiver1975

Thank you @jcar87 for the fix

DeepDiver1975 avatar Jun 11 '25 07:06 DeepDiver1975