conan-center-index icon indicating copy to clipboard operation
conan-center-index copied to clipboard

thorvg: add version 1.0-pre1

Open theashraf opened this issue 1 year ago • 11 comments

Summary

Changes to recipe: thorvg/1.0-pre1

Motivation

There are lots of improvements since 0.14.10.

Details

https://github.com/thorvg/thorvg/compare/v0.14.10...v1.0-pre1


theashraf avatar Oct 11 '24 05:10 theashraf

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 11 '24 05:10 CLAassistant

Conan v1 pipeline :x:

[!WARNING] Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

Conan v2 pipeline :x:

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

conan-center-bot avatar Oct 11 '24 05:10 conan-center-bot

Hi @theashraf thanks a lot for your PR! Do you have any insight into how long it will take the 1.0 version to be released? If it's "right around the corner", we might want to hold on and merge directly that, but if there's a use-case for having the prerelease version available, I'm all for it too!

Either way, I'll launch this build from our side to see if the new version compiles find with the current recipe/test package, let's see!

AbrilRBS avatar Oct 14 '24 06:10 AbrilRBS

Conan v1 pipeline :x:

[!WARNING] Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

Failure in build 2 (ec8800b0741c0699bf5e6da8ed5b553f6d25d1dc):

  • thorvg/0.14.10: CI failed to create some packages (All logs)

    Logs for packageID 3026f481238cccaf4886337e3cf0836829ab980b:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=7
    os=Linux
    [options]
    thorvg:shared=False
    
    [...]
    -- Conan: Component target declared 'libjpeg-turbo::turbojpeg-static'
    -- Conan: Target declared 'libjpeg-turbo::libjpeg-turbo'
    -- Conan: Target declared 'PNG::PNG'
    -- Conan: Target declared 'ZLIB::ZLIB'
    -- Conan: Component target declared 'WebP::webpdecoder'
    -- Conan: Component target declared 'WebP::sharpyuv'
    -- Conan: Component target declared 'WebP::webp'
    -- Conan: Component target declared 'WebP::webpdemux'
    -- Conan: Component target declared 'WebP::libwebpmux'
    -- Conan: Target declared 'libwebp::libwebp'
    -- Configuring done
    -- Generating done
    -- Build files have been written to: /home/conan/workspace/prod-v1/bsr/cci-d0adc045/recipes/thorvg/all/test_package/build/Release
    thorvg/0.14.10 (test package): CMake command: cmake --build "/home/conan/workspace/prod-v1/bsr/cci-d0adc045/recipes/thorvg/all/test_package/build/Release" '--' '-j3'
    
    ----Running------
    > cmake --build "/home/conan/workspace/prod-v1/bsr/cci-d0adc045/recipes/thorvg/all/test_package/build/Release" '--' '-j3'
    -----------------
    Scanning dependencies of target test_package
    [ 50%] Building CXX object CMakeFiles/test_package.dir/test_package.cpp.o
    CMakeFiles/test_package.dir/build.make:81: recipe for target 'CMakeFiles/test_package.dir/test_package.cpp.o' failed
    CMakeFiles/Makefile2:94: recipe for target 'CMakeFiles/test_package.dir/all' failed
    Makefile:102: recipe for target 'all' failed
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_POLICY_DEFAULT_CMP0091
    
    
    /home/conan/workspace/prod-v1/bsr/cci-d0adc045/recipes/thorvg/all/test_package/test_package.cpp: In function ‘int main()’:
    /home/conan/workspace/prod-v1/bsr/cci-d0adc045/recipes/thorvg/all/test_package/test_package.cpp:7:52: error: no matching function for call to ‘tvg::Initializer::init(int, tvg::CanvasEngine)’
         tvg::Initializer::init(0, tvg::CanvasEngine::Sw);
                                                        ^
    In file included from /home/conan/workspace/prod-v1/bsr/cci-d0adc045/recipes/thorvg/all/test_package/test_package.cpp:1:0:
    /home/conan/workspace/prod-v1/bsr/110070/cfedd/.conan/data/thorvg/0.14.10/_/_/package/3026f481238cccaf4886337e3cf0836829ab980b/include/thorvg.h:1731:19: note: candidate: static tvg::Result tvg::Initializer::init(tvg::CanvasEngine, uint32_t)
         static Result init(CanvasEngine engine, uint32_t threads) noexcept;
                       ^~~~
    /home/conan/workspace/prod-v1/bsr/110070/cfedd/.conan/data/thorvg/0.14.10/_/_/package/3026f481238cccaf4886337e3cf0836829ab980b/include/thorvg.h:1731:19: note:   no known conversion for argument 1 from ‘int’ to ‘tvg::CanvasEngine’
    make[2]: *** [CMakeFiles/test_package.dir/test_package.cpp.o] Error 1
    make[1]: *** [CMakeFiles/test_package.dir/all] Error 2
    make: *** [all] Error 2
    WARN: **************************************************
    WARN: *** Conan 1 is legacy and on a deprecation path **
    WARN: *********** Please upgrade to Conan 2 ************
    WARN: **************************************************
    thorvg/0.14.10 (test package): WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    thorvg/0.14.10 (test package): WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    ERROR: thorvg/0.14.10 (test package): Error in build() method, line 21
    	cmake.build()
    	ConanException: Error 2 while executing cmake --build "/home/conan/workspace/prod-v1/bsr/cci-d0adc045/recipes/thorvg/all/test_package/build/Release" '--' '-j3'
    
  • thorvg/1.0-pre1: Didn't run or was cancelled before finishing

  • thorvg/0.14.1: Didn't run or was cancelled before finishing

  • thorvg/0.14.6: Didn't run or was cancelled before finishing

  • thorvg/0.13.8: Didn't run or was cancelled before finishing

  • thorvg/0.14.5: Didn't run or was cancelled before finishing

  • thorvg/0.13.7: Didn't run or was cancelled before finishing

  • thorvg/0.14.2: Didn't run or was cancelled before finishing

  • thorvg/0.14.4: Didn't run or was cancelled before finishing

  • thorvg/0.14.0: Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline :x:

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 2 (ec8800b0741c0699bf5e6da8ed5b553f6d25d1dc):

  • thorvg/1.0-pre1: Didn't run or was cancelled before finishing

  • thorvg/0.14.10: Didn't run or was cancelled before finishing

  • thorvg/0.14.5: Didn't run or was cancelled before finishing

  • thorvg/0.14.2: Didn't run or was cancelled before finishing

  • thorvg/0.14.6: CI failed to create some packages (All logs)

    Logs for packageID 485a3748ab98065649e7d2da744b5505ee70d7cf:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.cppstd=17
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    
    [...]
    -- Using Conan toolchain: /home/conan/workspace/prod-v2/bsr/cci-77b7539a/recipes/thorvg/all/test_package/build/gcc-11-x86_64-17-release/generators/conan_toolchain.cmake
    -- Conan toolchain: Defining architecture flag: -m64
    -- Conan toolchain: C++ Standard 17 with extensions OFF
    -- The CXX compiler identification is GNU 11.4.0
    -- Check for working CXX compiler: /usr/local/bin/c++
    -- Check for working CXX compiler: /usr/local/bin/c++ -- works
    -- Detecting CXX compiler ABI info
    -- Detecting CXX compiler ABI info - done
    -- Detecting CXX compile features
    -- Detecting CXX compile features - done
    -- Conan: Target declared 'thorvg::thorvg'
    -- Conan: Component target declared 'libjpeg-turbo::jpeg-static'
    -- Conan: Component target declared 'libjpeg-turbo::turbojpeg-static'
    -- Conan: Target declared 'libjpeg-turbo::libjpeg-turbo'
    -- Conan: Target declared 'PNG::PNG'
    -- Conan: Target declared 'ZLIB::ZLIB'
    -- Conan: Component target declared 'WebP::webpdecoder'
    -- Conan: Component target declared 'WebP::sharpyuv'
    -- Conan: Component target declared 'WebP::webp'
    -- Conan: Component target declared 'WebP::webpdemux'
    -- Conan: Component target declared 'WebP::libwebpmux'
    -- Conan: Target declared 'libwebp::libwebp'
    -- Configuring done
    -- Generating done
    -- Build files have been written to: /home/conan/workspace/prod-v2/bsr/cci-77b7539a/recipes/thorvg/all/test_package/build/gcc-11-x86_64-17-release
    
    thorvg/0.14.6 (test package): Running CMake.build()
    thorvg/0.14.6 (test package): RUN: cmake --build "/home/conan/workspace/prod-v2/bsr/cci-77b7539a/recipes/thorvg/all/test_package/build/gcc-11-x86_64-17-release" -- -j3
    Scanning dependencies of target test_package
    [ 50%] Building CXX object CMakeFiles/test_package.dir/test_package.cpp.o
    /home/conan/workspace/prod-v2/bsr/cci-77b7539a/recipes/thorvg/all/test_package/test_package.cpp: In function 'int main()':
    /home/conan/workspace/prod-v2/bsr/cci-77b7539a/recipes/thorvg/all/test_package/test_package.cpp:7:28: error: cannot convert 'int' to 'tvg::CanvasEngine'
        7 |     tvg::Initializer::init(0, tvg::CanvasEngine::Sw);
          |                            ^
          |                            |
          |                            int
    In file included from /home/conan/workspace/prod-v2/bsr/cci-77b7539a/recipes/thorvg/all/test_package/test_package.cpp:1:
    /home/conan/workspace/prod-v2/bsr/98261/ffafa/p/thorva2246f342bca7/p/include/thorvg.h:1799:37: note:   initializing argument 1 of 'static tvg::Result tvg::Initializer::init(tvg::CanvasEngine, uint32_t)'
     1799 |     static Result init(CanvasEngine engine, uint32_t threads) noexcept;
          |                        ~~~~~~~~~~~~~^~~~~~
    CMakeFiles/test_package.dir/build.make:62: recipe for target 'CMakeFiles/test_package.dir/test_package.cpp.o' failed
    make[2]: *** [CMakeFiles/test_package.dir/test_package.cpp.o] Error 1
    CMakeFiles/Makefile2:75: recipe for target 'CMakeFiles/test_package.dir/all' failed
    make[1]: *** [CMakeFiles/test_package.dir/all] Error 2
    Makefile:83: recipe for target 'all' failed
    make: *** [all] Error 2
    
    ERROR: thorvg/0.14.6 (test package): Error in build() method, line 21
    	cmake.build()
    	ConanException: Error 2 while executing
    
  • thorvg/0.14.4: Didn't run or was cancelled before finishing

  • thorvg/0.14.0: Didn't run or was cancelled before finishing

  • thorvg/0.13.7: Didn't run or was cancelled before finishing

  • thorvg/0.14.1: Didn't run or was cancelled before finishing

  • thorvg/0.13.8: Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

conan-center-bot avatar Oct 14 '24 06:10 conan-center-bot

Conan v1 pipeline :x:

[!WARNING] Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

Conan v2 pipeline :x:

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

conan-center-bot avatar Oct 21 '24 13:10 conan-center-bot

Conan v1 pipeline :x:

[!WARNING] Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

Conan v2 pipeline :x:

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

conan-center-bot avatar Oct 21 '24 13:10 conan-center-bot

@theashraf seeing that pre2 has already been released and after checking with @franramirez688 , I think we'll want to wait until the final 1.0 version is released before merging this.

Feel free to update the version meanwhile if it helps prepare for the eventual release, and make sure to fill the access request so this can be merged once the final version is released, thanks!

AbrilRBS avatar Oct 21 '24 13:10 AbrilRBS

Conan v1 pipeline :x:

[!WARNING] Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

Failure in build 7 (0234110161ae49615d52d24b0d384489d5b608a2):

  • thorvg/1.0-pre1: CI failed to create some packages (All logs)

    Logs for packageID 3026f481238cccaf4886337e3cf0836829ab980b:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=7
    os=Linux
    [options]
    thorvg:shared=False
    
    [...]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=7
    os=Linux
    [options]
    thorvg:shared=False
    [build_requires]
    [env]
    [conf]
    tools.system.package_manager:mode=install
    tools.system.package_manager:sudo=True
    
    Version ranges solved
        Version range '>=1.2.11 <2' required by 'libpng/1.6.43' resolved to 'zlib/1.3.1' in local cache
    
    thorvg/1.0-pre1 (test package): Installing package
    Requirements
        libjpeg-turbo/3.0.2 from 'conan-center' - Cache
        libpng/1.6.43 from 'conan-center' - Cache
        libwebp/1.4.0 from 'conan-center' - Cache
        thorvg/1.0-pre1 from local cache - Cache
        zlib/1.3.1 from 'conan-center' - Cache
    Packages
        libjpeg-turbo/3.0.2:a17200140369a0b4951bb8b6d3e90f3a8248d9a9 - Cache
        libpng/1.6.43:9378b660d2155d53cea1126fa13164a3bfa59f2c - Cache
        libwebp/1.4.0:6322a9a56f029bb63526b01c9e32f1e334e3f0cb - Cache
        thorvg/1.0-pre1:3026f481238cccaf4886337e3cf0836829ab980b - Cache
        zlib/1.3.1:d50a0d523d98c15bb147b18fa7d203887c38be8b - Cache
    
    Installing (downloading, building) binaries...
    libjpeg-turbo/3.0.2: Already installed!
    libwebp/1.4.0: Already installed!
    zlib/1.3.1: Already installed!
    libpng/1.6.43: Already installed!
    thorvg/1.0-pre1: Already installed!
    thorvg/1.0-pre1 (test package): Generator 'CMakeDeps' calling 'generate()'
    thorvg/1.0-pre1 (test package): Generator 'VirtualRunEnv' calling 'generate()'
    thorvg/1.0-pre1 (test package): Generator txt created conanbuildinfo.txt
    thorvg/1.0-pre1 (test package): Calling generate()
    WARN: **************************************************
    WARN: *** Conan 1 is legacy and on a deprecation path **
    WARN: *********** Please upgrade to Conan 2 ************
    WARN: **************************************************
    thorvg/1.0-pre1 (test package): WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    thorvg/1.0-pre1 (test package): WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    ERROR: thorvg/1.0-pre1 (test package): Error in generate() method, line 21
    	tc.variables["THORVG_VERSION_LESS_1"] = self.dependencies[self.tested_reference_str].ref.version.major < 1
    	TypeError: '<' not supported between instances of 'method' and 'int'
    
  • thorvg/0.14.6: Didn't run or was cancelled before finishing

  • thorvg/0.14.0: Didn't run or was cancelled before finishing

  • thorvg/0.14.10: Didn't run or was cancelled before finishing

  • thorvg/0.15.1: Didn't run or was cancelled before finishing

  • thorvg/0.14.1: Didn't run or was cancelled before finishing

  • thorvg/0.14.2: Didn't run or was cancelled before finishing

  • thorvg/0.13.7: Didn't run or was cancelled before finishing

  • thorvg/0.14.5: Didn't run or was cancelled before finishing

  • thorvg/0.14.4: Didn't run or was cancelled before finishing

  • thorvg/0.13.8: Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

conan-center-bot avatar Oct 21 '24 14:10 conan-center-bot

Conan v1 pipeline :x:

[!WARNING] Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

Conan v2 pipeline :x:

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

conan-center-bot avatar Oct 21 '24 14:10 conan-center-bot

Conan v1 pipeline :heavy_check_mark:

[!WARNING] Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 9 (347be5e83637a53859bbce24f8ae9ad4ba1048cb):

  • thorvg/0.15.1: Built 18 packages out of 22 (All logs)

  • thorvg/0.14.5: Built 18 packages out of 22 (All logs)

  • thorvg/0.14.0: Built 18 packages out of 22 (All logs)

  • thorvg/0.14.4: Built 18 packages out of 22 (All logs)

  • thorvg/1.0-pre1: Built 18 packages out of 22 (All logs)

  • thorvg/0.13.7: Built 18 packages out of 22 (All logs)

  • thorvg/0.13.8: Built 18 packages out of 22 (All logs)

  • thorvg/0.14.1: Built 18 packages out of 22 (All logs)

  • thorvg/0.14.6: Built 18 packages out of 22 (All logs)

  • thorvg/0.14.2: Built 18 packages out of 22 (All logs)

  • thorvg/0.14.10: Built 18 packages out of 22 (All logs)


Conan v2 pipeline :heavy_check_mark:

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 9 (347be5e83637a53859bbce24f8ae9ad4ba1048cb):

  • thorvg/1.0-pre1: All packages built successfully! (All logs)

  • thorvg/0.13.8: All packages built successfully! (All logs)

  • thorvg/0.14.10: All packages built successfully! (All logs)

  • thorvg/0.14.2: All packages built successfully! (All logs)

  • thorvg/0.15.1: All packages built successfully! (All logs)

  • thorvg/0.14.5: All packages built successfully! (All logs)

  • thorvg/0.14.6: All packages built successfully! (All logs)

  • thorvg/0.14.0: All packages built successfully! (All logs)

  • thorvg/0.14.4: All packages built successfully! (All logs)

  • thorvg/0.13.7: All packages built successfully! (All logs)

  • thorvg/0.14.1: All packages built successfully! (All logs)

conan-center-bot avatar Oct 21 '24 21:10 conan-center-bot

@theashraf seeing that pre2 has already been released and after checking with @franramirez688 , I think we'll want to wait until the final 1.0 version is released before merging this.

Feel free to update the version meanwhile if it helps prepare for the eventual release, and make sure to fill the access request so this can be merged once the final version is released, thanks!

Thanks a lot @AbrilRBS for your help, will wait until stable v1 is available 🙏🏼

theashraf avatar Oct 22 '24 05:10 theashraf